Updating ChangeLog since release of v17.5.0#2443
Conversation
WalkthroughAdds a new CHANGELOG.md entry for version 17.5.0 documenting changes to SqlServerDsc.Common including moving functions into individual files and using ModuleBuilder for assembly, along with integration test refactors and command adjustments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
CHANGELOG.md (2)
12-19:⚠️ Potential issue | 🟡 MinorApply Markdown formatting + wrap long lines.
Module/product names should be italicized and long list items wrapped.
✍️ Suggested diff
-- SqlServerDsc.Common - - Moved functions into individual files and use ModuleBuilder to assemble. -- SqlServerDsc - - Refactor integration tests for _SQL Server Reporting Services_ and _Power BI_ - _Report Server_ ([issue `#2431`](https://github.com/dsccommunity/SqlServerDsc/issues/2431)). - - `Connect-Sql` create connection and server objects as per documentation. - - `Invoke-SqlDscQuery` remove disconnect as there is not an explicit connect. +- _SqlServerDsc.Common_ + - Moved functions into individual files and use _ModuleBuilder_ to assemble. +- _SqlServerDsc_ + - Refactor integration tests for _SQL Server Reporting Services_ and _Power BI_ + _Report Server_ ([issue `#2431`](https://github.com/dsccommunity/SqlServerDsc/issues/2431)). + - `Connect-Sql` create connection and server objects as per + documentation. + - `Invoke-SqlDscQuery` remove disconnect as there is not an explicit connect.As per coding guidelines: “Format resource/module/product names using italic”, and “Wrap lines at word boundaries when over 80 characters (except tables/code blocks)”.
23-25:⚠️ Potential issue | 🟡 MinorFix issue link format.
The issue reference uses backticks and does not match the required format.
✍️ Suggested diff
- prereleases ([issue `#2437`](https://github.com/dsccommunity/SqlServerDsc/issues/2437)). + prereleases ([issue `#2437`](https://github.com/dsccommunity/SqlServerDsc/issues/2437)).As per coding guidelines: “Reference issues using format issue #<issue_number> in CHANGELOG.md”.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
=====================================
Coverage 94% 94%
=====================================
Files 225 225
Lines 10769 10769
=====================================
Hits 10142 10142
Misses 627 627
🚀 New features to boost your workflow:
|
This change is