Skip to content

Fix enable TLS 1.2 prerequisite tests#2446

Merged
johlju merged 2 commits intodsccommunity:mainfrom
johlju:fix/issue-#2441
Feb 1, 2026
Merged

Fix enable TLS 1.2 prerequisite tests#2446
johlju merged 2 commits intodsccommunity:mainfrom
johlju:fix/issue-#2441

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Feb 1, 2026

Pull Request (PR) description

  • SqlServerDsc
    • Added SChannelDsc as a required module for integration tests and enabled the
      prerequisites tests Ensure TLS 1.2 is enabled (issue #2441).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner February 1, 2026 09:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 1, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Added SChannelDsc as a required test dependency and enabled the previously skipped "Ensure TLS 1.2 is enabled" integration test by removing the -Skip modifiers. Changelog updated and the dependency configured to allow prerelease (latest).

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Documented addition of SChannelDsc as a required module and the enablement of the TLS 1.2 integration test context under Unreleased changes.
Module dependency manifest
RequiredModules.psd1
Added SChannelDsc required module entry with Version = 'latest' and Parameters = @{ AllowPrerelease = $true }.
Integration tests (enablement)
tests/Integration/Commands/Prerequisites.Integration.Tests.ps1, tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1
Removed -Skip from the Ensure TLS 1.2 is enabled test context(s) so the TLS 1.2 prerequisite checks run in integration scenarios (e.g., Integration_SQL2025).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the changes, references the linked issue #2441, and documents the updated files (CHANGELOG.md and integration tests).
Linked Issues check ✅ Passed All coding requirements from issue #2441 are met: SChannelDsc added as required module, Skip modifier removed from TLS 1.2 test context, and CHANGELOG updated.
Out of Scope Changes check ✅ Passed All changes are directly related to the objectives in issue #2441: adding SChannelDsc dependency and enabling the TLS 1.2 prerequisite test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Fix enable TLS 1.2 prerequisite tests' is directly related to the main change: enabling TLS 1.2 prerequisite tests by removing the Skip modifier and adding SChannelDsc as a required module. It accurately summarizes the core objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94%. Comparing base (dfe01bc) to head (5f9dc72).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2446   +/-   ##
=====================================
  Coverage     94%     94%           
=====================================
  Files        225     225           
  Lines      10769   10769           
=====================================
  Hits       10142   10142           
  Misses       627     627           
Flag Coverage Δ
unit 94% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju johlju changed the title Add SChannelDsc module and enable TLS 1.2 prerequisite tests Fix enable TLS 1.2 prerequisite tests Feb 1, 2026
@johlju johlju merged commit 78a2c04 into dsccommunity:main Feb 1, 2026
2 of 6 checks passed
@johlju johlju deleted the fix/issue-#2441 branch February 1, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Ensure TLS 1.2 is enabled integration test

1 participant