Skip to content

Fix enable TLS 1.2 prerequisite tests #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johlju merged 2 commits into from
Feb 1, 2026
Merged

Fix enable TLS 1.2 prerequisite tests #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f9dc72
Add SChannelDsc module and enable TLS 1.2 prerequisite tests
johlju Feb 1, 2026
a65ede0
Merge branch 'main' into fix/issue-#2441
johlju Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- SqlServerDsc
- Updated Pester test guidance in AI instructions in community style guidelines.
- Added SChannelDsc as a required module for integration tests and enabled the
prerequisites tests `Ensure TLS 1.2 is enabled` ([issue #2441](https://github.com/dsccommunity/SqlServerDsc/issues/2441)).

## [17.5.0] - 2026-01-30

Expand Down
6 changes: 6 additions & 0 deletions RequiredModules.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@
StorageDsc = '5.1.0'
NetworkingDsc = '9.0.0'
WSManDsc = '3.1.1'
SChannelDsc = @{
Version = 'latest'
Parameters = @{
AllowPrerelease = $true
}
}

# Prerequisite modules for documentation.
#'DscResource.DocGenerator' = 'latest'
Expand Down
2 changes: 1 addition & 1 deletion tests/Integration/Commands/Prerequisites.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ Describe 'Prerequisites' {
}
}

Context 'Ensure TLS 1.2 is enabled' -Tag @('Integration_SQL2025') -Skip {
Context 'Ensure TLS 1.2 is enabled' -Tag @('Integration_SQL2025') {
# SQL Server 2025 installation can fail when TLS 1.2 is disabled:
# https://learn.microsoft.com/en-us/sql/sql-server/sql-server-2025-known-issues?view=sql-server-ver17#sql-server-2025-installation-fails-when-tls-12-is-disabled
It 'Should have TLS 1.2 enabled on the node' -Tag @('Integration_SQL2025') {
Expand Down
2 changes: 1 addition & 1 deletion tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}
}

Context 'Ensure TLS 1.2 is enabled' -Tag @('Integration_SQL2025') -Skip {
Context 'Ensure TLS 1.2 is enabled' -Tag @('Integration_SQL2025') {
# SQL Server 2025 installation can fail when TLS 1.2 is disabled:
# https://learn.microsoft.com/en-us/sql/sql-server/sql-server-2025-known-issues?view=sql-server-ver17#sql-server-2025-installation-fails-when-tls-12-is-disabled
It 'Should have TLS 1.2 enabled on the node' -Tag @('Integration_SQL2025') {
Expand Down