fix: replace bare except with except Exception in win32.py#282
Open
KeloYuan wants to merge 1 commit into
Open
Conversation
Bare except: catches SystemExit and KeyboardInterrupt.
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows notification backend to avoid using a bare except: when loading the tray icon, ensuring that control-flow exceptions like KeyboardInterrupt and SystemExit are not inadvertently swallowed.
Changes:
- Replaced a bare
except:withexcept Exception:aroundwin32gui.LoadImage(...)in the Win32 backend.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces bare
except:withexcept Exception:inntfy/backends/win32.py(line 40).Why
Bare
except:catchesSystemExitandKeyboardInterrupt, which can mask Ctrl+C handling.