Skip to content

Commit 3c319da

Browse files
committed
Trim protobuf sizes now that strings are interned
1 parent c9860b9 commit 3c319da

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

pthread_trace.cc

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919
#include <cstdlib>
2020
#include <cstring>
2121
#include <ctime>
22-
#include <map>
2322
#include <mutex>
2423
#include <thread>
25-
#include <vector>
2624

2725
namespace {
2826

@@ -330,10 +328,10 @@ void write_trace_begin(trace_type e, EventType event_type = EventType::SLICE_BEG
330328
proto::buffer<4> type;
331329
type.write(static_cast<uint64_t>(TrackEvent::type), static_cast<uint64_t>(event_type));
332330

333-
proto::buffer<256> name_buf;
331+
proto::buffer<4> name_buf;
334332
name_buf.write(static_cast<uint64_t>(TrackEvent::name_iid), static_cast<uint64_t>(e));
335333

336-
proto::buffer<256> track_event;
334+
proto::buffer<8> track_event;
337335
track_event.write(static_cast<uint64_t>(TracePacket::track_event), name_buf, type, track_uuid);
338336

339337
proto::buffer<16> timestamp;
@@ -346,7 +344,7 @@ void write_trace_begin(trace_type e, EventType event_type = EventType::SLICE_BEG
346344
sequence_flags.write(static_cast<uint64_t>(TracePacket::sequence_flags),
347345
static_cast<uint64_t>(SequenceFlags::NEEDS_INCREMENTAL_STATE));
348346

349-
proto::buffer<256> trace_packet;
347+
proto::buffer<32> trace_packet;
350348
trace_packet.write(1, timestamp, track_event, trusted_packet_sequence_id, sequence_flags);
351349

352350
thread.write(trace_packet);
@@ -364,7 +362,7 @@ void write_trace_end() {
364362
proto::buffer<4> type;
365363
type.write(static_cast<uint64_t>(TrackEvent::type), static_cast<uint64_t>(EventType::SLICE_END));
366364

367-
proto::buffer<256> track_event;
365+
proto::buffer<8> track_event;
368366
track_event.write(static_cast<uint64_t>(TracePacket::track_event), type, track_uuid);
369367

370368
proto::buffer<16> timestamp;
@@ -377,7 +375,7 @@ void write_trace_end() {
377375
sequence_flags.write(static_cast<uint64_t>(TracePacket::sequence_flags),
378376
static_cast<uint64_t>(SequenceFlags::NEEDS_INCREMENTAL_STATE));
379377

380-
proto::buffer<256> trace_packet;
378+
proto::buffer<32> trace_packet;
381379
trace_packet.write(1, timestamp, track_event, trusted_packet_sequence_id, sequence_flags);
382380

383381
thread.write(trace_packet);

0 commit comments

Comments
 (0)