feat: yarn version berry workspace autocompletion#54
Open
devthejo wants to merge 1 commit into
Open
Conversation
Closed
dsifford
requested changes
Apr 4, 2022
Owner
dsifford
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This looks pretty good, except that it will not work under certain circumstances. See comments for explanation.
| sed -n 's/^ \{2\}"\([^"]*\)": {$/\1/p' <<< "$workspaces_info" | ||
| ) | ||
| COMPREPLY=($(compgen -W "${MAPFILE[*]}" -- "$cur")) | ||
| if [ -f .yarnrc.yml ]; then |
Owner
There was a problem hiding this comment.
This will only work properly if you are completing yarn from the root of the project. If you call yarn workspace <Tab> from any child directories, this will fail.
See the following snippet for how the script locates the package.json file.
yarn-completion/yarn-completion.bash
Lines 35 to 41 in 73fe678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @dsifford ,
first I want to thank you for this great autocompletion script,
I use yarn berry version (v2/v3) and the completion work for most of commands except for
yarn workspace, this PR solve this, detecting yarn v2/v3 and use correct completion command for workspaces adressing this issue and makin my life easier ;):#49