Skip to content

Commit e390a3f

Browse files
committed
Mark (with TODO comments) part of functions to be reworked to use enums or booleans.
1 parent 49a35a3 commit e390a3f

26 files changed

Lines changed: 34 additions & 34 deletions

dss/dss_capi_gr/ICNData.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def GMRac(self, Value):
6060

6161
@property
6262
def GMRUnits(self):
63-
return self._lib.CNData_Get_GMRUnits()
63+
return self._lib.CNData_Get_GMRUnits() #TODO: use enum
6464

6565
@GMRUnits.setter
6666
def GMRUnits(self, Value):
@@ -78,7 +78,7 @@ def Radius(self, Value):
7878

7979
@property
8080
def RadiusUnits(self):
81-
return self._lib.CNData_Get_RadiusUnits()
81+
return self._lib.CNData_Get_RadiusUnits() #TODO: use enum
8282

8383
@RadiusUnits.setter
8484
def RadiusUnits(self, Value):
@@ -87,7 +87,7 @@ def RadiusUnits(self, Value):
8787

8888
@property
8989
def ResistanceUnits(self):
90-
return self._lib.CNData_Get_ResistanceUnits()
90+
return self._lib.CNData_Get_ResistanceUnits() #TODO: use enum
9191

9292
@ResistanceUnits.setter
9393
def ResistanceUnits(self, Value):

dss/dss_capi_gr/ICktElement.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def OCPDevIndex(self):
234234
@property
235235
def OCPDevType(self):
236236
'''(read-only) 0=None; 1=Fuse; 2=Recloser; 3=Relay; Type of OCP controller device'''
237-
return self._lib.CktElement_Get_OCPDevType()
237+
return self._lib.CktElement_Get_OCPDevType() #TODO: use enum
238238

239239
@property
240240
def PhaseLosses(self):

dss/dss_capi_gr/IGenerators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def ForcedON(self, Value):
2222
@property
2323
def Model(self):
2424
'''Generator Model'''
25-
return self._lib.Generators_Get_Model()
25+
return self._lib.Generators_Get_Model() #TODO: use enum
2626

2727
@Model.setter
2828
def Model(self, Value):

dss/dss_capi_gr/ILineCodes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def Rmatrix(self, Value):
110110

111111
@property
112112
def Units(self):
113-
return self._lib.LineCodes_Get_Units()
113+
return self._lib.LineCodes_Get_Units() # TODO: use enum
114114

115115
@Units.setter
116116
def Units(self, Value):

dss/dss_capi_gr/ILineGeometries.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def Cmatrix(self, Frequency, Length, Units):
8787
@property
8888
def Units(self):
8989
self._lib.LineGeometries_Get_Units_GR()
90-
return self._get_int32_gr_array()
90+
return self._get_int32_gr_array() #TODO: use enum
9191

9292
@Units.setter
9393
def Units(self, Value):

dss/dss_capi_gr/ILineSpacings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def Nconds(self, Value):
3232

3333
@property
3434
def Units(self):
35-
return self._lib.LineSpacings_Get_Units()
35+
return self._lib.LineSpacings_Get_Units() #TODO: use enum
3636

3737
@Units.setter
3838
def Units(self, Value):

dss/dss_capi_gr/ILines.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def TotalCust(self):
220220

221221
@property
222222
def Units(self):
223-
return self._lib.Lines_Get_Units()
223+
return self._lib.Lines_Get_Units() #TODO: use enum
224224

225225
@Units.setter
226226
def Units(self, Value):

dss/dss_capi_gr/ILoads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def Spectrum(self, Value):
179179
@property
180180
def Status(self):
181181
'''Response to load multipliers: Fixed (growth only), Exempt (no LD curve), Variable (all).'''
182-
return self._lib.Loads_Get_Status()
182+
return self._lib.Loads_Get_Status() #TODO: use enum
183183

184184
@Status.setter
185185
def Status(self, Value):

dss/dss_capi_gr/IParallel.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def ActiveParallel(self):
3333
(read) Sets ON/OFF (1/0) Parallel features of the Engine
3434
(write) Delivers if the Parallel features of the Engine are Active
3535
'''
36-
return self._lib.Parallel_Get_ActiveParallel()
36+
return self._lib.Parallel_Get_ActiveParallel() #TODO: use boolean for consistency
3737

3838
@ActiveParallel.setter
3939
def ActiveParallel(self, Value):
@@ -68,7 +68,7 @@ def ConcatenateReports(self):
6868
(read) Reads the values of the ConcatenateReports option (1=enabled, 0=disabled)
6969
(write) Enable/Disable (1/0) the ConcatenateReports option for extracting monitors data
7070
'''
71-
return self._lib.Parallel_Get_ConcatenateReports()
71+
return self._lib.Parallel_Get_ConcatenateReports() #TODO: use boolean for consistency
7272

7373
@ConcatenateReports.setter
7474
def ConcatenateReports(self, Value):

dss/dss_capi_gr/IReactors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def SpecType(self):
1717
How the reactor data was provided: 1=kvar, 2=R+jX, 3=R and X matrices, 4=sym components.
1818
Depending on this value, only some properties are filled or make sense in the context.
1919
'''
20-
return self._lib.Reactors_Get_SpecType()
20+
return self._lib.Reactors_Get_SpecType() #TODO: use enum
2121

2222
@property
2323
def IsDelta(self):

0 commit comments

Comments
 (0)