Skip to content

Commit 129e214

Browse files
authored
Do not wait in VerdaCompute.create_instance (#3723)
Previously, `VerdaCompute.create_instance` would block for up to 3 minutes while the SDK was waiting for the instance to leave the `ORDERED` status. This could hurt performance (the database connection is blocked while waiting) and reliability (server restarts or exceptions during the wait cause the instance to be orphaned). Use the newly introduced Verda SDK option to avoid the wait in `create_instance()`, so that it is performed by subsequent `update_provisioning_data()` calls instead.
1 parent c0c011c commit 129e214

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,11 @@ gcp = [
226226
"dstack[server]",
227227
]
228228
datacrunch = [
229-
"verda; python_version >= '3.10'",
229+
"verda>=1.23.0; python_version >= '3.10'",
230230
"dstack[server]",
231231
]
232232
verda = [
233-
"verda; python_version >= '3.10'",
233+
"verda>=1.23.0; python_version >= '3.10'",
234234
"dstack[server]",
235235
]
236236
kubernetes = [

src/dstack/_internal/core/backends/verda/compute.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ def _deploy_instance(
258258
is_spot=is_spot,
259259
location=location,
260260
os_volume={"name": "OS volume", "size": disk_size},
261+
wait_for_status=None, # return asap
261262
)
262263
except APIException as e:
263264
# FIXME: Catch only no capacity errors

0 commit comments

Comments
 (0)