Skip to content

Commit 2365a2b

Browse files
authored
[Feature]: The Run details page should display the same fields as the Run list page #2751 (#2769)
1 parent 93656a4 commit 2365a2b

1 file changed

Lines changed: 36 additions & 38 deletions

File tree

  • frontend/src/pages/Runs/Details/RunDetails

frontend/src/pages/Runs/Details/RunDetails/index.tsx

Lines changed: 36 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,11 @@ export const RunDetails = () => {
8888
<div>{format(new Date(runData.submitted_at), DATE_TIME_FORMAT)}</div>
8989
</div>
9090

91+
<div>
92+
<Box variant="awsui-key-label">{t('projects.run.finished_at')}</Box>
93+
<div>{runData.terminated_at ? format(new Date(runData.terminated_at), DATE_TIME_FORMAT) : '-'}</div>
94+
</div>
95+
9196
<div>
9297
<Box variant="awsui-key-label">{t('projects.run.status')}</Box>
9398
<div>
@@ -105,51 +110,44 @@ export const RunDetails = () => {
105110
<div>{getRunError(runData)}</div>
106111
</div>
107112

108-
{getRunListItemBackend(runData) && (
109-
<div>
110-
<Box variant="awsui-key-label">{t('projects.run.backend')}</Box>
111-
<div>{getRunListItemBackend(runData)}</div>
112-
</div>
113-
)}
113+
<div>
114+
<Box variant="awsui-key-label">{t('projects.run.priority')}</Box>
115+
<div>{getRunPriority(runData)}</div>
116+
</div>
114117

115-
{getRunListItemRegion(runData) && (
116-
<div>
117-
<Box variant="awsui-key-label">{t('projects.run.region')}</Box>
118-
<div>{getRunListItemRegion(runData)}</div>
119-
</div>
120-
)}
118+
<div>
119+
<Box variant="awsui-key-label">{t('projects.run.cost')}</Box>
120+
<div>${runData.cost}</div>
121+
</div>
121122

122-
{getRunListItemInstanceId(runData) && (
123-
<div>
124-
<Box variant="awsui-key-label">{t('projects.run.instance_id')}</Box>
125-
<div>{getRunListItemInstanceId(runData)}</div>
126-
</div>
127-
)}
123+
<div>
124+
<Box variant="awsui-key-label">{t('projects.run.price')}</Box>
125+
<div>{getRunListItemPrice(runData)}</div>
126+
</div>
128127

129-
{getRunListItemResources(runData) && (
130-
<div>
131-
<Box variant="awsui-key-label">{t('projects.run.resources')}</Box>
132-
<div>{getRunListItemResources(runData)}</div>
133-
</div>
134-
)}
128+
<div>
129+
<Box variant="awsui-key-label">{t('projects.run.resources')}</Box>
130+
<div>{getRunListItemResources(runData)}</div>
131+
</div>
135132

136-
{getRunListItemSpot(runData) && (
137-
<div>
138-
<Box variant="awsui-key-label">{t('projects.run.spot')}</Box>
139-
<div>{getRunListItemSpot(runData)}</div>
140-
</div>
141-
)}
133+
<div>
134+
<Box variant="awsui-key-label">{t('projects.run.region')}</Box>
135+
<div>{getRunListItemRegion(runData)}</div>
136+
</div>
142137

143-
{getRunListItemPrice(runData) && (
144-
<div>
145-
<Box variant="awsui-key-label">{t('projects.run.price')}</Box>
146-
<div>{getRunListItemPrice(runData)}</div>
147-
</div>
148-
)}
138+
<div>
139+
<Box variant="awsui-key-label">{t('projects.run.instance_id')}</Box>
140+
<div>{getRunListItemInstanceId(runData)}</div>
141+
</div>
149142

150143
<div>
151-
<Box variant="awsui-key-label">{t('projects.run.cost')}</Box>
152-
<div>${runData.cost}</div>
144+
<Box variant="awsui-key-label">{t('projects.run.spot')}</Box>
145+
<div>{getRunListItemSpot(runData)}</div>
146+
</div>
147+
148+
<div>
149+
<Box variant="awsui-key-label">{t('projects.run.backend')}</Box>
150+
<div>{getRunListItemBackend(runData)}</div>
153151
</div>
154152
</ColumnLayout>
155153

0 commit comments

Comments
 (0)