Type check cli.commands (#3014)

Author: r4victor

pyproject.toml

@@ -83,6 +83,7 @@ include = [
     "src/dstack/plugins",
     "src/dstack/_internal/server",
     "src/dstack/_internal/core/services",
+    "src/dstack/_internal/cli/commands",
     "src/dstack/_internal/cli/services/configurators",
 ]
 ignore = [

src/dstack/_internal/cli/commands/__init__.py

@@ -54,15 +54,15 @@ def _command(self, args: argparse.Namespace):
 
 
 class APIBaseCommand(BaseCommand):
-    api: Client = None
+    api: Client
 
     def _register(self):
         self._parser.add_argument(
             "--project",
             help="The name of the project. Defaults to [code]$DSTACK_PROJECT[/]",
             metavar="NAME",
             default=os.getenv("DSTACK_PROJECT"),
-        ).completer = ProjectNameCompleter()
+        ).completer = ProjectNameCompleter()  # type: ignore[attr-defined]
 
     def _command(self, args: argparse.Namespace):
         configure_logging()

src/dstack/_internal/cli/commands/apply.py

@@ -1,7 +1,7 @@
 import argparse
 from pathlib import Path
 
-from argcomplete import FilesCompleter
+from argcomplete import FilesCompleter  # type: ignore[attr-defined]
 
 from dstack._internal.cli.commands import APIBaseCommand
 from dstack._internal.cli.services.configurators import (
@@ -48,7 +48,7 @@ def _register(self):
                 " Defaults to [code]$PWD/.dstack.yml[/]"
             ),
             dest="configuration_file",
-        ).completer = FilesCompleter(allowednames=["*.yml", "*.yaml"])
+        ).completer = FilesCompleter(allowednames=["*.yml", "*.yaml"])  # type: ignore[attr-defined]
         self._parser.add_argument(
             "-y",
             "--yes",

src/dstack/_internal/cli/commands/attach.py

@@ -61,7 +61,7 @@ def _register(self):
             type=int,
             default=0,
         )
-        self._parser.add_argument("run_name").completer = RunNameCompleter()
+        self._parser.add_argument("run_name").completer = RunNameCompleter()  # type: ignore[attr-defined]
 
     def _command(self, args: argparse.Namespace):
         super()._command(args)

src/dstack/_internal/cli/commands/completion.py

@@ -17,4 +17,4 @@ def _register(self):
 
     def _command(self, args):
         super()._command(args)
-        print(argcomplete.shellcode(["dstack"], shell=args.shell))
+        print(argcomplete.shellcode(["dstack"], shell=args.shell))  # type: ignore[attr-defined]

src/dstack/_internal/cli/commands/delete.py

@@ -1,7 +1,7 @@
 import argparse
 from pathlib import Path
 
-from argcomplete import FilesCompleter
+from argcomplete import FilesCompleter  # type: ignore[attr-defined]
 
 from dstack._internal.cli.commands import APIBaseCommand
 from dstack._internal.cli.services.configurators import (
@@ -24,7 +24,7 @@ def _register(self):
             metavar="FILE",
             help="The path to the configuration file. Defaults to [code]$PWD/.dstack.yml[/]",
             dest="configuration_file",
-        ).completer = FilesCompleter(allowednames=["*.yml", "*.yaml"])
+        ).completer = FilesCompleter(allowednames=["*.yml", "*.yaml"])  # type: ignore[attr-defined]
         self._parser.add_argument(
             "-y",
             "--yes",

src/dstack/_internal/cli/commands/fleet.py

@@ -48,7 +48,7 @@ def _register(self):
         delete_parser.add_argument(
             "name",
             help="The name of the fleet",
-        ).completer = FleetNameCompleter()
+        ).completer = FleetNameCompleter()  # type: ignore[attr-defined]
         delete_parser.add_argument(
             "-i",
             "--instance",

src/dstack/_internal/cli/commands/gateway.py

@@ -68,7 +68,7 @@ def _register(self):
         delete_parser.set_defaults(subfunc=self._delete)
         delete_parser.add_argument(
             "name", help="The name of the gateway"
-        ).completer = GatewayNameCompleter()
+        ).completer = GatewayNameCompleter()  # type: ignore[attr-defined]
         delete_parser.add_argument(
             "-y", "--yes", action="store_true", help="Don't ask for confirmation"
         )
@@ -79,7 +79,7 @@ def _register(self):
         update_parser.set_defaults(subfunc=self._update)
         update_parser.add_argument(
             "name", help="The name of the gateway"
-        ).completer = GatewayNameCompleter()
+        ).completer = GatewayNameCompleter()  # type: ignore[attr-defined]
         update_parser.add_argument(
             "--set-default", action="store_true", help="Set it the default gateway for the project"
         )

src/dstack/_internal/cli/commands/logs.py

@@ -30,7 +30,7 @@ def _register(self):
             type=int,
             default=0,
         )
-        self._parser.add_argument("run_name").completer = RunNameCompleter(all=True)
+        self._parser.add_argument("run_name").completer = RunNameCompleter(all=True)  # type: ignore[attr-defined]
 
     def _command(self, args: argparse.Namespace):
         super()._command(args)

src/dstack/_internal/cli/commands/metrics.py

@@ -26,7 +26,7 @@ class MetricsCommand(APIBaseCommand):
 
     def _register(self):
         super()._register()
-        self._parser.add_argument("run_name").completer = RunNameCompleter()
+        self._parser.add_argument("run_name").completer = RunNameCompleter()  # type: ignore[attr-defined]
         self._parser.add_argument(
             "-w",
             "--watch",