Skip to content

Commit 631c086

Browse files
committed
Add FIXME
1 parent 32a2418 commit 631c086

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/dstack/_internal/server/background/pipeline_tasks/instances/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def __init__(
7272
workers_num: int = 20,
7373
queue_lower_limit_factor: float = 0.5,
7474
queue_upper_limit_factor: float = 2.0,
75-
min_processing_interval: timedelta = timedelta(seconds=10),
75+
min_processing_interval: timedelta = timedelta(seconds=15),
7676
lock_timeout: timedelta = timedelta(seconds=30),
7777
heartbeat_trigger: timedelta = timedelta(seconds=15),
7878
) -> None:

src/dstack/_internal/server/services/fleets.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,8 @@ async def delete_fleets(
799799
)
800800
instance_models_ids = list(res.scalars().unique().all())
801801
if len(instance_models_ids) != len(instances_ids):
802+
# FIXME: In case of many instances, it can always fail.
803+
# Try locking and waiting for all instances here until requests are queued for processing.
802804
msg = (
803805
"Failed to delete fleets: fleet instances are being processed currently. Try again later."
804806
if instance_nums is None

0 commit comments

Comments
 (0)