Skip to content

Commit 7a026ba

Browse files
committed
Select with .load_only(FleetModel.name)
1 parent 7d80cef commit 7a026ba

File tree

5 files changed

+2
-6
lines changed

5 files changed

+2
-6
lines changed

src/dstack/_internal/server/background/tasks/process_fleets.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ async def _process_next_fleet():
6060
async def _process_fleet(session: AsyncSession, fleet_model: FleetModel):
6161
logger.debug("Processing fleet %s", fleet_model.name)
6262
# Refetch to load related attributes.
63-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
6463
res = await session.execute(
6564
select(FleetModel)
6665
.where(FleetModel.id == fleet_model.id)

src/dstack/_internal/server/background/tasks/process_gateways.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ async def _process_connection(conn: GatewayConnection):
110110
async def _process_submitted_gateway(session: AsyncSession, gateway_model: GatewayModel):
111111
logger.info("%s: started gateway provisioning", fmt(gateway_model))
112112
# Refetch to load related attributes.
113-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
114113
res = await session.execute(
115114
select(GatewayModel)
116115
.where(GatewayModel.id == gateway_model.id)
@@ -157,7 +156,6 @@ async def _process_provisioning_gateway(
157156
session: AsyncSession, gateway_model: GatewayModel
158157
) -> None:
159158
# Refetch to load related attributes.
160-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
161159
res = await session.execute(
162160
select(GatewayModel)
163161
.where(GatewayModel.id == gateway_model.id)

src/dstack/_internal/server/background/tasks/process_running_jobs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ async def _process_next_running_job():
132132

133133
async def _process_running_job(session: AsyncSession, job_model: JobModel):
134134
# Refetch to load related attributes.
135-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
136135
res = await session.execute(
137136
select(JobModel)
138137
.where(JobModel.id == job_model.id)

src/dstack/_internal/server/background/tasks/process_submitted_jobs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ async def _process_next_submitted_job():
154154
async def _process_submitted_job(session: AsyncSession, job_model: JobModel):
155155
logger.debug("%s: provisioning has started", fmt(job_model))
156156
# Refetch to load related attributes.
157-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
158157
res = await session.execute(
159158
select(JobModel).where(JobModel.id == job_model.id).options(joinedload(JobModel.instance))
160159
)

src/dstack/_internal/server/background/tasks/process_volumes.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from dstack._internal.core.models.volumes import VolumeStatus
88
from dstack._internal.server.db import get_db, get_session_ctx
99
from dstack._internal.server.models import (
10+
FleetModel,
1011
InstanceModel,
1112
ProjectModel,
1213
VolumeAttachmentModel,
@@ -49,7 +50,6 @@ async def process_submitted_volumes():
4950
async def _process_submitted_volume(session: AsyncSession, volume_model: VolumeModel):
5051
logger.info("Started submitted volume %s processing", volume_model.name)
5152
# Refetch to load related attributes.
52-
# joinedload produces LEFT OUTER JOIN that can't be used with FOR UPDATE.
5353
res = await session.execute(
5454
select(VolumeModel)
5555
.where(VolumeModel.id == volume_model.id)
@@ -59,6 +59,7 @@ async def _process_submitted_volume(session: AsyncSession, volume_model: VolumeM
5959
joinedload(VolumeModel.attachments)
6060
.joinedload(VolumeAttachmentModel.instance)
6161
.joinedload(InstanceModel.fleet)
62+
.load_only(FleetModel.name)
6263
)
6364
.execution_options(populate_existing=True)
6465
)

0 commit comments

Comments
 (0)