Skip to content

Commit 8651e9a

Browse files
author
Andrey Cheptsov
committed
runpod: restore edit_pod rationale comment
- keep explicit context for why edit_pod is used - restore TODO describing future removal path
1 parent 4e5413f commit 8651e9a

File tree

1 file changed

+3
-1
lines changed
  • src/dstack/_internal/core/backends/runpod

1 file changed

+3
-1
lines changed

src/dstack/_internal/core/backends/runpod/compute.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,10 @@ def run_job(
210210

211211
instance_id = resp["id"]
212212

213-
# Keep the same post-create registry-auth flow for both GPU and CPU paths.
213+
# Call edit_pod to pass container_registry_auth_id.
214214
# Expect a long time (~5m) for the pod to pick up the creds.
215+
# TODO: remove editPod once Runpod's create mutations support docker's username/password
216+
# (or a reliable containerRegistryAuthId at create time).
215217
if container_registry_auth_id is not None:
216218
instance_id = self.api_client.edit_pod(
217219
pod_id=instance_id,

0 commit comments

Comments
 (0)