Skip to content

Commit 8a10fc7

Browse files
committed
Simplify submitted-jobs termination helper
1 parent b29118f commit 8a10fc7

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

src/dstack/_internal/server/background/scheduled_tasks/submitted_jobs.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from contextlib import AsyncExitStack
55
from dataclasses import dataclass
66
from datetime import datetime, timedelta
7-
from typing import List, Optional, Union, cast
7+
from typing import List, Optional, Union
88

99
from sqlalchemy import exists, func, select
1010
from sqlalchemy.ext.asyncio import AsyncSession
@@ -53,6 +53,7 @@
5353
JobTerminationReason,
5454
Requirements,
5555
Run,
56+
RunSpec,
5657
)
5758
from dstack._internal.core.models.volumes import Volume
5859
from dstack._internal.core.services.profiles import get_termination
@@ -427,7 +428,7 @@ async def _prepare_job_volumes(
427428
session: AsyncSession,
428429
job_model: JobModel,
429430
project: ProjectModel,
430-
run_spec,
431+
run_spec: RunSpec,
431432
job: Job,
432433
) -> Optional[_PreparedJobVolumes]:
433434
try:
@@ -964,11 +965,11 @@ async def _terminate_submitted_job(
964965
session: AsyncSession,
965966
job_model: JobModel,
966967
reason: JobTerminationReason,
967-
message: object = common_utils.UNSET,
968+
message: Optional[str] = None,
968969
):
969970
job_model.termination_reason = reason
970-
if message is not common_utils.UNSET:
971-
job_model.termination_reason_message = cast(Optional[str], message)
971+
if message is not None:
972+
job_model.termination_reason_message = message
972973
switch_job_status(session, job_model, JobStatus.TERMINATING)
973974
await _mark_job_processed(session=session, job_model=job_model)
974975

0 commit comments

Comments
 (0)