Resolve Review Comments and Update docs

Author: Bihan Rana

docs/docs/concepts/backends.md

@@ -579,34 +579,6 @@ gcloud projects list --format="json(projectId)"
     Using private subnets assumes that both the `dstack` server and users can access the configured VPC's private subnets.
     Additionally, [Cloud NAT](https://cloud.google.com/nat/docs/overview) must be configured to provide access to external resources for provisioned instances.
 
-## Hot Aisle
-
-Log in to the SSH TUI as described in the [Hot Aisle Quick Start :material-arrow-top-right-thin:{ .external }](https://hotaisle.xyz/quick-start/).
-Create a new team and generate an API key for the member in the team.
-
-Then, go ahead and configure the backend:
-
-<div editor-title="~/.dstack/server/config.yml">
-
-```yaml
-projects:
-- name: main
-  backends:
-    - type: hotaisle
-      team_handle: hotaisle-team-handle
-      creds:
-        type: api_key
-        api_key: 9c27a4bb7a8e472fae12ab34.3f2e3c1db75b9a0187fd2196c6b3e56d2b912e1c439ba08d89e7b6fcd4ef1d3f
-```
-
-</div>
-
-??? info "Required permissions"
-    The API key must have the following roles assigned:
-
-    * **Owner role for the user** - Required for creating and managing SSH keys
-    * **Operator role for the team** - Required for managing virtual machines within the team
-
 ## Lambda
 
 Log into your [Lambda Cloud :material-arrow-top-right-thin:{ .external }](https://lambdalabs.com/service/gpu-cloud) account, click API keys in the sidebar, and then click the `Generate API key`
@@ -937,6 +909,104 @@ projects:
 
 </div>
 
+## AMD Developer Cloud
+Log into your [AMD Developer Cloud :material-arrow-top-right-thin:{ .external }](https://amd.digitalocean.com/login) account. Click `API` in the sidebar and click the button `Generate New Token`. 
+
+Then, go ahead and configure the backend:
+
+<div editor-title="~/.dstack/server/config.yml">
+
+```yaml
+projects:
+- name: main
+  backends:
+    - type: amddevcloud
+      project_name: my-amd-project
+      creds:
+        type: api_key
+        api_key: dop_v1_71ea79a0c4bf2ffa70ac9d2a7b2689d2b41768567b22ebabe58a80066dcc5e92
+```
+
+</div>
+
+??? info "Project Name"
+    **project_name** configuration is optional. If it is not provided, the default project is used.
+
+??? info "Required permissions"
+    The API key must have the following scopes assigned:
+
+    * **account** - read
+    * **droplet** - create,read,update,delete,admin
+    * **project** - create,read,update,delete
+    * **regions** - read
+    * **sizes**   - read
+    * **ssh_key**  - create,read,update,delete
+
+
+
+## Digital Ocean
+Log into your [Digital Ocean :material-arrow-top-right-thin:{ .external }](https://cloud.digitalocean.com/login) account. Click `API` in the sidebar and click the button `Generate New Token`. 
+
+Then, go ahead and configure the backend:
+
+<div editor-title="~/.dstack/server/config.yml">
+
+```yaml
+projects:
+- name: main
+  backends:
+    - type: digitalocean
+      project_name: my-digital-ocean-project
+      creds:
+        type: api_key
+        api_key: dop_v1_71ea79a0c4bf2ffa70ac9d2a7b2689d2b41768567b22ebabe58a80066dcc5e92
+```
+
+</div>
+
+??? info "Project Name"
+    **project_name** configuration is optional. If it is not provided, the default project is used.
+
+??? info "Required permissions"
+    The API key must have the following scopes assigned:
+
+    * **account** - read
+    * **droplet** - create,read,update,delete,admin
+    * **project** - create,read,update,delete
+    * **regions** - read
+    * **sizes**   - read
+    * **ssh_key**  - create,read,update,delete
+
+
+## Hot Aisle
+
+Log in to the SSH TUI as described in the [Hot Aisle Quick Start :material-arrow-top-right-thin:{ .external }](https://hotaisle.xyz/quick-start/).
+Create a new team and generate an API key for the member in the team.
+
+Then, go ahead and configure the backend:
+
+<div editor-title="~/.dstack/server/config.yml">
+
+```yaml
+projects:
+- name: main
+  backends:
+    - type: hotaisle
+      team_handle: hotaisle-team-handle
+      creds:
+        type: api_key
+        api_key: 9c27a4bb7a8e472fae12ab34.3f2e3c1db75b9a0187fd2196c6b3e56d2b912e1c439ba08d89e7b6fcd4ef1d3f
+```
+
+</div>
+
+??? info "Required permissions"
+    The API key must have the following roles assigned:
+
+    * **Owner role for the user** - Required for creating and managing SSH keys
+    * **Operator role for the team** - Required for managing virtual machines within the team
+
+
 ## CloudRift
 
 Log into your [CloudRift :material-arrow-top-right-thin:{ .external }](https://console.cloudrift.ai/) console, click `API Keys` in the sidebar and click the button to create a new API key.

docs/docs/reference/server/config.yml.md

@@ -126,22 +126,6 @@ to configure [backends](../../concepts/backends.md) and other [server-level sett
             type:
                 required: true
 
-##### `projects[n].backends[type=hotaisle]` { #hotaisle data-toc-label="hotaisle" }
-
-#SCHEMA# dstack._internal.core.backends.hotaisle.models.HotAisleBackendConfigWithCreds
-    overrides:
-        show_root_heading: false
-        type:
-            required: true
-        item_id_prefix: hotaisle-
-
-###### `projects[n].backends[type=hotaisle].creds` { #hotaisle-creds data-toc-label="creds" }
-
-#SCHEMA# dstack._internal.core.backends.hotaisle.models.HotAisleAPIKeyCreds
-    overrides:
-        show_root_heading: false
-        type:
-            required: true
 
 ##### `projects[n].backends[type=lambda]` { #lambda data-toc-label="lambda" }
 
@@ -332,6 +316,57 @@ to configure [backends](../../concepts/backends.md) and other [server-level sett
         type:
             required: true
 
+##### `projects[n].backends[type=amddevcloud]` { #amddevcloud data-toc-label="amddevcloud" }
+
+#SCHEMA# dstack._internal.core.backends.digitalocean_base.models.BaseDigitalOceanBackendConfigWithCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+        item_id_prefix: amddevcloud-
+
+###### `projects[n].backends[type=amddevcloud].creds` { #amddevcloud-creds data-toc-label="creds" }
+
+#SCHEMA# dstack._internal.core.backends.digitalocean_base.models.BaseDigitalOceanAPIKeyCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+
+##### `projects[n].backends[type=digitalocean]` { #digitalocean data-toc-label="digitalocean" }
+
+#SCHEMA# dstack._internal.core.backends.digitalocean_base.models.BaseDigitalOceanBackendConfigWithCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+        item_id_prefix: digitalocean-
+
+###### `projects[n].backends[type=digitalocean].creds` { #digitalocean-creds data-toc-label="creds" }
+
+#SCHEMA# dstack._internal.core.backends.digitalocean_base.models.BaseDigitalOceanAPIKeyCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+
+##### `projects[n].backends[type=hotaisle]` { #hotaisle data-toc-label="hotaisle" }
+
+#SCHEMA# dstack._internal.core.backends.hotaisle.models.HotAisleBackendConfigWithCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+        item_id_prefix: hotaisle-
+
+###### `projects[n].backends[type=hotaisle].creds` { #hotaisle-creds data-toc-label="creds" }
+
+#SCHEMA# dstack._internal.core.backends.hotaisle.models.HotAisleAPIKeyCreds
+    overrides:
+        show_root_heading: false
+        type:
+            required: true
+
 ##### `projects[n].backends[type=cloudrift]` { #cloudrift data-toc-label="cloudrift" }
 
 #SCHEMA# dstack._internal.core.backends.cloudrift.models.CloudRiftBackendConfigWithCreds

src/dstack/_internal/core/backends/amddevcloud/configurator.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from dstack._internal.core.backends.amddevcloud.backend import AMDDevCloudBackend
 from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
 from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
@@ -19,6 +21,8 @@ def get_backend(self, record) -> BaseDigitalOceanBackend:
         config = self._get_config(record)
         return AMDDevCloudBackend(config=config, api_url=self.API_URL)
 
-    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds):
+    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds, project_name: Optional[str] = None):
         api_client = DigitalOceanAPIClient(creds.api_key, self.API_URL)
         api_client.validate_api_key()
+        if project_name:
+            api_client.validate_project_name(project_name)

src/dstack/_internal/core/backends/digitalocean/configurator.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from dstack._internal.core.backends.base.configurator import BackendRecord
 from dstack._internal.core.backends.digitalocean.backend import DigitalOceanBackend
 from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
@@ -22,6 +24,8 @@ def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
         config = self._get_config(record)
         return DigitalOceanBackend(config=config, api_url=self.API_URL)
 
-    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds):
+    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds, project_name: Optional[str] = None):
         api_client = DigitalOceanAPIClient(creds.api_key, self.API_URL)
         api_client.validate_api_key()
+        if project_name:
+            api_client.validate_project_name(project_name)

src/dstack/_internal/core/backends/digitalocean_base/api_client.py

@@ -27,6 +27,14 @@ def validate_api_key(self) -> bool:
                 )
             raise e
 
+    def validate_project_name(self, project_name: str) -> bool:
+        if self.get_project_id(project_name) is None:
+            raise_invalid_credentials_error(
+                fields=[["config", "project_name"]],
+                details=f"Project with name '{project_name}' does not exist",
+            )
+        return True
+
     def list_ssh_keys(self) -> List[Dict[str, Any]]:
         response = self._make_request("GET", "/v2/account/keys")
         response.raise_for_status()
@@ -83,7 +91,6 @@ def _make_request(
     ) -> requests.Response:
         url = f"{self.base_url}{endpoint}"
         headers = {
-            "Content-Type": "application/json",
             "Authorization": f"Bearer {self.api_key}",
         }
 

src/dstack/_internal/core/backends/digitalocean_base/compute.py

@@ -88,15 +88,18 @@ def create_instance(
             name=f"dstack-{instance_config.project_name}",
             public_key=project_ssh_key.public,
         )
-
         size_slug = instance_offer.instance.name
 
         if not instance_offer.instance.resources.gpus:
             backend_specific_commands = SETUP_COMMANDS + DOCKER_INSTALL_COMMANDS
         else:
             backend_specific_commands = SETUP_COMMANDS
 
-        project_id = self.api_client.get_project_id(self.config.project_name)
+        project_id = (
+            self.api_client.get_project_id(self.config.project_name)
+            if self.config.project_name
+            else None
+        )
         droplet_config = {
             "name": instance_name,
             "region": instance_offer.region,
@@ -155,9 +158,9 @@ def _get_image_for_instance(self, instance_offer: InstanceOfferWithAvailability)
             return "ubuntu-24-04-x64"
 
         gpu_count = len(instance_offer.instance.resources.gpus)
-        gpu_name = instance_offer.instance.resources.gpus[0].name
+        gpu_vendor = instance_offer.instance.resources.gpus[0].vendor
 
-        if gpu_name == "MI300X":
+        if gpu_vendor == "amd":
             # AMD GPU
             return "digitaloceanai-rocmjupyter"
         else:

src/dstack/_internal/core/backends/digitalocean_base/configurator.py

@@ -1,4 +1,5 @@
 import json
+from typing import Optional
 
 from dstack._internal.core.backends.base.configurator import (
     BackendRecord,
@@ -20,7 +21,7 @@ class BaseDigitalOceanConfigurator(Configurator):
     def validate_config(
         self, config: BaseDigitalOceanBackendConfigWithCreds, default_creds_enabled: bool
     ):
-        self._validate_creds(config.creds)
+        self._validate_creds(config.creds, config.project_name)
 
     def create_backend(
         self, project_name: str, config: BaseDigitalOceanBackendConfigWithCreds
@@ -49,5 +50,5 @@ def _get_config(self, record: BackendRecord) -> BaseDigitalOceanConfig:
             creds=BaseDigitalOceanCreds.parse_raw(record.auth),
         )
 
-    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds):
+    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds, project_name: Optional[str] = None):
         pass

src/dstack/_internal/core/backends/digitalocean_base/models.py

@@ -19,10 +19,10 @@ class BaseDigitalOceanBackendConfig(CoreModel):
         Literal["amddevcloud", "digitalocean"],
         Field(description="The type of backend"),
     ] = "digitalocean"
-    project_name: Annotated[str, Field(description="The name of the DigitalOcean project")] = None
+    project_name: Annotated[Optional[str], Field(description="The name of the project")] = None
     regions: Annotated[
         Optional[List[str]],
-        Field(description="The list of DigitalOcean regions. Omit to use all regions"),
+        Field(description="The list of regions. Omit to use all regions"),
     ] = None
 
 

src/dstack/_internal/core/backends/models.py

@@ -23,7 +23,6 @@
 from dstack._internal.core.backends.digitalocean_base.models import (
     BaseDigitalOceanBackendConfig,
     BaseDigitalOceanBackendConfigWithCreds,
-    BaseDigitalOceanBackendFileConfigWithCreds,
 )
 from dstack._internal.core.backends.dstack.models import (
     DstackBackendConfig,
@@ -129,7 +128,7 @@
     CloudRiftBackendConfigWithCreds,
     CudoBackendConfigWithCreds,
     DataCrunchBackendConfigWithCreds,
-    BaseDigitalOceanBackendFileConfigWithCreds,
+    BaseDigitalOceanBackendConfigWithCreds,
     GCPBackendFileConfigWithCreds,
     HotAisleBackendFileConfigWithCreds,
     KubernetesBackendFileConfigWithCreds,