Skip to content

Commit c678c60

Browse files
committed
[UI]: Fixes after review #3473
1 parent a126912 commit c678c60

2 files changed

Lines changed: 24 additions & 6 deletions

File tree

frontend/src/pages/Project/Details/Events/index.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import React from 'react';
22
import { useTranslation } from 'react-i18next';
33
import { useNavigate, useParams } from 'react-router-dom';
44

5-
import { Button, Header, SpaceBetween } from 'components';
5+
import { Button, Container, Header, Loader, SpaceBetween } from 'components';
66

77
import { useBreadcrumbs } from 'hooks';
88
import { ROUTES } from 'routes';
9+
import { useGetProjectQuery } from 'services/project';
910

1011
import { EventList } from 'pages/Events/List';
1112

@@ -14,6 +15,7 @@ export const Events: React.FC = () => {
1415
const params = useParams();
1516
const paramProjectName = params.projectName ?? '';
1617
const navigate = useNavigate();
18+
const { data, isLoading } = useGetProjectQuery({ name: paramProjectName });
1719

1820
useBreadcrumbs([
1921
{
@@ -31,9 +33,16 @@ export const Events: React.FC = () => {
3133
]);
3234

3335
const goToEventsPage = () => {
34-
navigate(ROUTES.EVENTS.LIST + `?within_projects=${paramProjectName}`);
36+
navigate(ROUTES.EVENTS.LIST + `?within_projects=${data?.project_id}`);
3537
};
3638

39+
if (isLoading || !data)
40+
return (
41+
<Container>
42+
<Loader />
43+
</Container>
44+
);
45+
3746
return (
3847
<EventList
3948
renderHeader={() => {
@@ -48,7 +57,7 @@ export const Events: React.FC = () => {
4857
/>
4958
);
5059
}}
51-
permanentFilters={{ within_projects: [paramProjectName] }}
60+
permanentFilters={{ within_projects: [data.project_id] }}
5261
showFilters={false}
5362
/>
5463
);

frontend/src/pages/User/Details/Events/index.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import React, { useState } from 'react';
22
import { useTranslation } from 'react-i18next';
33
import { useNavigate, useParams } from 'react-router-dom';
44

5-
import { Button, Header, SegmentedControl, SpaceBetween } from 'components';
5+
import { Button, Container, Header, Loader, SegmentedControl, SpaceBetween } from 'components';
66

77
import { useBreadcrumbs } from 'hooks';
88
import { ROUTES } from 'routes';
9+
import { useGetUserQuery } from 'services/user';
910

1011
import { EventList } from 'pages/Events/List';
1112

@@ -15,6 +16,7 @@ export const Events: React.FC = () => {
1516
const paramUserName = params.userName ?? '';
1617
const navigate = useNavigate();
1718
const [filterParamName, setFilterParamName] = useState<keyof TEventListFilters>('actors');
19+
const { data, isLoading } = useGetUserQuery({ name: paramUserName });
1820

1921
useBreadcrumbs([
2022
{
@@ -32,9 +34,16 @@ export const Events: React.FC = () => {
3234
]);
3335

3436
const goToEventsPage = () => {
35-
navigate(ROUTES.EVENTS.LIST + `?${filterParamName}=${paramUserName}`);
37+
navigate(ROUTES.EVENTS.LIST + `?${filterParamName}=${data?.id}`);
3638
};
3739

40+
if (isLoading || !data)
41+
return (
42+
<Container>
43+
<Loader />
44+
</Container>
45+
);
46+
3847
return (
3948
<EventList
4049
renderHeader={() => {
@@ -57,7 +66,7 @@ export const Events: React.FC = () => {
5766
/>
5867
);
5968
}}
60-
permanentFilters={{ [filterParamName]: [paramUserName] }}
69+
permanentFilters={{ [filterParamName]: [data.id] }}
6170
showFilters={false}
6271
/>
6372
);

0 commit comments

Comments
 (0)