Skip to content

Commit cbb13f0

Browse files
Bihan  RanaBihan  Rana
authored andcommitted
Resolve all review comments
1 parent 397cf98 commit cbb13f0

File tree

1 file changed

+8
-2
lines changed
  • src/dstack/_internal/core/compatibility

1 file changed

+8
-2
lines changed

src/dstack/_internal/core/compatibility/runs.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,14 @@ def get_run_spec_excludes(run_spec: RunSpec) -> IncludeExcludeDictType:
9696
router = run_spec.configuration.router
9797
if router is None:
9898
configuration_excludes["router"] = True
99-
elif isinstance(router, SGLangServiceRouterConfig) and router.pd_disaggregation is False:
100-
configuration_excludes["router"] = {"pd_disaggregation": True}
99+
elif isinstance(router, SGLangServiceRouterConfig):
100+
router_excludes: IncludeExcludeDictType = {}
101+
if router.pd_disaggregation is False:
102+
router_excludes["pd_disaggregation"] = True
103+
if router.managed_by == "gateway":
104+
router_excludes["managed_by"] = True
105+
if router_excludes:
106+
configuration_excludes["router"] = router_excludes
101107
if run_spec.configuration.https is None:
102108
configuration_excludes["https"] = True
103109

0 commit comments

Comments
 (0)