Reject negative retry durations

Author: pragnyanramtha

src/dstack/_internal/cli/services/profile.py

@@ -8,8 +8,8 @@
     Profile,
     ProfileRetry,
     SpotPolicy,
-    parse_duration,
     parse_max_duration,
+    parse_retry_duration,
 )
 
 
@@ -179,4 +179,6 @@ def max_duration(v: str) -> int:
 
 
 def retry_duration(v: str) -> int:
-    return parse_duration(v)
+    duration = parse_retry_duration(v)
+    assert duration is not None
+    return duration

src/dstack/_internal/core/models/profiles.py

@@ -68,6 +68,13 @@ def parse_duration(v: Optional[Union[int, str]]) -> Optional[int]:
     return Duration.parse(v)
 
 
+def parse_retry_duration(v: Optional[Union[int, str]]) -> Optional[int]:
+    duration = parse_duration(v)
+    if duration is not None and duration < 0:
+        raise ValueError("Duration cannot be negative")
+    return duration
+
+
 def parse_max_duration(v: Optional[Union[int, str, bool]]) -> Optional[Union[Literal["off"], int]]:
     return parse_off_duration(v)
 
@@ -136,7 +143,7 @@ class ProfileRetry(generate_dual_core_model(ProfileRetryConfig)):
         ),
     ] = None
 
-    _validate_duration = validator("duration", pre=True, allow_reuse=True)(parse_duration)
+    _validate_duration = validator("duration", pre=True, allow_reuse=True)(parse_retry_duration)
 
     @root_validator
     def _validate_fields(cls, values):

src/tests/_internal/cli/services/configurators/test_profile.py

@@ -1,6 +1,8 @@
 import argparse
 from typing import List, Tuple
 
+import pytest
+
 from dstack._internal.cli.services.profile import (
     apply_profile_args,
     register_profile_args,
@@ -68,6 +70,10 @@ def test_retry_duration(self):
         profile.retry = ProfileRetry(on_events=None, duration="1h")
         assert profile.dict() == modified.dict()
 
+    def test_retry_duration_rejects_negative(self):
+        with pytest.raises(SystemExit):
+            apply_args(Profile(name="test"), ["--retry-duration", "-1"])
+
 
 def apply_args(profile: Profile, args: List[str]) -> Tuple[Profile, argparse.Namespace]:
     parser = argparse.ArgumentParser()

src/tests/_internal/core/models/test_profiles.py

@@ -0,0 +1,17 @@
+import pytest
+from pydantic import ValidationError
+
+from dstack._internal.core.models.profiles import ProfileRetry, RetryEvent
+
+
+class TestProfileRetry:
+    @pytest.mark.parametrize("duration", [-1, "-1"])
+    def test_rejects_negative_duration(self, duration):
+        with pytest.raises(ValidationError, match="Duration cannot be negative"):
+            ProfileRetry(duration=duration)
+
+    def test_parses_duration(self):
+        retry = ProfileRetry(duration="1h", on_events=[RetryEvent.ERROR])
+
+        assert retry.duration == 3600
+        assert retry.on_events == [RetryEvent.ERROR]