Skip to content

Commit f0f273c

Browse files
authored
Fix long sqlite write transaction when provisioning instances (#3104)
1 parent 98aee00 commit f0f273c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/dstack/_internal/server/background/tasks/process_instances.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,6 @@ async def _create_instance(session: AsyncSession, instance: InstanceModel) -> No
578578
if placement_group_model is None: # error occurred
579579
continue
580580
session.add(placement_group_model)
581-
await session.flush()
582581
placement_group_models.append(placement_group_model)
583582
logger.debug(
584583
"Trying %s in %s/%s for $%0.4f per hour",
@@ -636,7 +635,9 @@ async def _create_instance(session: AsyncSession, instance: InstanceModel) -> No
636635
},
637636
)
638637
if instance.fleet_id and _is_fleet_master_instance(instance):
639-
# Clean up placement groups that did not end up being used
638+
# Clean up placement groups that did not end up being used.
639+
# Flush to update still uncommitted placement groups.
640+
await session.flush()
640641
await schedule_fleet_placement_groups_deletion(
641642
session=session,
642643
fleet_id=instance.fleet_id,

0 commit comments

Comments
 (0)