Skip to content

[Internal]: Drop hardcoded regions from the backend template #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Jun 4, 2025
Merged

[Internal]: Drop hardcoded regions from the backend template #2734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/dstack/_internal/core/backends/template/configurator.py.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ from dstack._internal.core.models.backends.base import (
BackendType,
)

# TODO: Add all supported regions and default regions
REGIONS = []


class {{ backend_name }}Configurator(Configurator):
TYPE = BackendType.{{ backend_name|upper }}
Expand All @@ -31,13 +28,11 @@ class {{ backend_name }}Configurator(Configurator):
self, config: {{ backend_name }}BackendConfigWithCreds, default_creds_enabled: bool
):
self._validate_creds(config.creds)
# TODO: Validate additional config parameters if any
# TODO: If possible, validate config.regions and any other config parameters

def create_backend(
self, project_name: str, config: {{ backend_name }}BackendConfigWithCreds
) -> BackendRecord:
if config.regions is None:
config.regions = REGIONS
return BackendRecord(
config={{ backend_name }}StoredConfig(
**{{ backend_name }}BackendConfig.__response__.parse_obj(config).dict()
Expand Down
Loading