Support file upload to gcs bucket#2737
Merged
r4victor merged 1 commit intodstackai:masterfrom Jun 5, 2025
Merged
Conversation
r4victor
reviewed
Jun 4, 2025
r4victor
reviewed
Jun 4, 2025
r4victor
reviewed
Jun 4, 2025
ee2fee6 to
8f1ba45
Compare
8f1ba45 to
9837ba3
Compare
r4victor
approved these changes
Jun 5, 2025
Collaborator
|
@colinjc, thanks! |
Contributor
|
@colinjc Quick question, have you tested the PR? It works? We haven't tested it on our side. |
Contributor
Author
|
I tested it against GCS, but not S3 |
haydnli-shopify
pushed a commit
to haydnli-shopify/dstack
that referenced
this pull request
Jun 10, 2025
haydnli-shopify
pushed a commit
to haydnli-shopify/dstack
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for uploading file blobs to GCS.