Skip to content

Support file upload to gcs bucket#2737

Merged
r4victor merged 1 commit intodstackai:masterfrom
colinjc:cc/06-03-support_file_upload_to_gcs_bucket
Jun 5, 2025
Merged

Support file upload to gcs bucket#2737
r4victor merged 1 commit intodstackai:masterfrom
colinjc:cc/06-03-support_file_upload_to_gcs_bucket

Conversation

@colinjc
Copy link
Copy Markdown
Contributor

@colinjc colinjc commented Jun 3, 2025

Add support for uploading file blobs to GCS.

@peterschmidt85 peterschmidt85 requested a review from r4victor June 3, 2025 22:06
Comment thread src/dstack/_internal/server/services/storage/gcs.py Outdated
Comment thread src/dstack/_internal/server/services/storage/__init__.py Outdated
Comment thread src/dstack/_internal/server/services/storage/base.py Outdated
Copy link
Copy Markdown
Collaborator

@r4victor r4victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

@colinjc colinjc force-pushed the cc/06-03-support_file_upload_to_gcs_bucket branch from ee2fee6 to 8f1ba45 Compare June 4, 2025 13:35
@colinjc colinjc force-pushed the cc/06-03-support_file_upload_to_gcs_bucket branch from 8f1ba45 to 9837ba3 Compare June 4, 2025 13:35
@colinjc colinjc requested a review from r4victor June 4, 2025 13:36
@r4victor r4victor merged commit d767132 into dstackai:master Jun 5, 2025
25 checks passed
@r4victor
Copy link
Copy Markdown
Collaborator

r4victor commented Jun 5, 2025

@colinjc, thanks!

@peterschmidt85
Copy link
Copy Markdown
Contributor

@colinjc Quick question, have you tested the PR? It works? We haven't tested it on our side.

@colinjc
Copy link
Copy Markdown
Contributor Author

colinjc commented Jun 10, 2025

I tested it against GCS, but not S3

haydnli-shopify pushed a commit to haydnli-shopify/dstack that referenced this pull request Jun 10, 2025
haydnli-shopify pushed a commit to haydnli-shopify/dstack that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants