Skip to content

2674 prop filter#2778

Merged
peterschmidt85 merged 3 commits intomasterfrom
2674_prop_filter
Jun 10, 2025
Merged

2674 prop filter#2778
peterschmidt85 merged 3 commits intomasterfrom
2674_prop_filter

Conversation

@olgenn
Copy link
Copy Markdown
Collaborator

@olgenn olgenn commented Jun 9, 2025

No description provided.

@olgenn olgenn requested a review from peterschmidt85 June 9, 2025 18:23
@olgenn olgenn self-assigned this Jun 9, 2025
Copy link
Copy Markdown
Contributor

@peterschmidt85 peterschmidt85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Find runs -> Filter runs by properties, otherwise good to merge!

@peterschmidt85 peterschmidt85 merged commit b859f53 into master Jun 10, 2025
25 checks passed
@peterschmidt85 peterschmidt85 deleted the 2674_prop_filter branch June 10, 2025 19:11
@peterschmidt85
Copy link
Copy Markdown
Contributor

@olgenn Found only after merging, there is a critical regression. If no filters are set, no runs are shown.

I DM-ed you a few examples I reproduced on https://sky.dstack.ai

It's very important to fix before the release. Worst case scenario, if we cannot fix before the release tomorrow, lets rollback the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants