Skip to content

Fix missing digitaloceanbase configurator methods #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bihan merged 1 commit into from
Sep 2, 2025
Merged

Fix missing digitaloceanbase configurator methods #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dstack/_internal/core/backends/amddevcloud/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Optional

from dstack._internal.core.backends.amddevcloud.backend import AMDDevCloudBackend
from dstack._internal.core.backends.base.configurator import BackendRecord
from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
from dstack._internal.core.backends.digitalocean_base.configurator import (
Expand All @@ -17,7 +18,7 @@ class AMDDevCloudConfigurator(BaseDigitalOceanConfigurator):
BACKEND_CLASS = AMDDevCloudBackend
API_URL = "https://api-amd.digitalocean.com"

def get_backend(self, record) -> BaseDigitalOceanBackend:
def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
config = self._get_config(record)
return AMDDevCloudBackend(config=config, api_url=self.API_URL)

Expand Down
17 changes: 10 additions & 7 deletions src/dstack/_internal/core/backends/digitalocean_base/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
)
from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
from dstack._internal.core.backends.digitalocean_base.models import (
AnyBaseDigitalOceanBackendConfig,
AnyBaseDigitalOceanCreds,
BaseDigitalOceanBackendConfig,
BaseDigitalOceanBackendConfigWithCreds,
Expand All @@ -33,16 +32,20 @@ def create_backend(
auth=BaseDigitalOceanCreds.parse_obj(config.creds).json(),
)

def get_backend_config(
self, record: BackendRecord, include_creds: bool
) -> AnyBaseDigitalOceanBackendConfig:
def get_backend_config_with_creds(
self, record: BackendRecord
) -> BaseDigitalOceanBackendConfigWithCreds:
config = self._get_config(record)
return BaseDigitalOceanBackendConfigWithCreds.__response__.parse_obj(config)

def get_backend_config_without_creds(
self, record: BackendRecord
) -> BaseDigitalOceanBackendConfig:
config = self._get_config(record)
if include_creds:
return BaseDigitalOceanBackendConfigWithCreds.__response__.parse_obj(config)
return BaseDigitalOceanBackendConfig.__response__.parse_obj(config)

def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
pass
raise NotImplementedError("Subclasses must implement get_backend")

def _get_config(self, record: BackendRecord) -> BaseDigitalOceanConfig:
return BaseDigitalOceanConfig.__response__(
Expand Down
Loading