Skip to content

Fix JobRunningPipeline not reclaiming stale jobs for terminating runs #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Apr 3, 2026
Merged

Fix JobRunningPipeline not reclaiming stale jobs for terminating runs #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dstack/_internal/server/background/pipeline_tasks/jobs_running.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ async def fetch(self, limit: int) -> list[JobRunningPipelineItem]:
JobModel.status.in_(
[JobStatus.PROVISIONING, JobStatus.PULLING, JobStatus.RUNNING]
),
RunModel.status.not_in([RunStatus.TERMINATING]),
or_(
# Process provisioning and pulling jobs quicker for low-latency provisioning.
# Active jobs processing can be less frequent to minimize contention with `RunPipeline`.
Expand All @@ -223,10 +222,11 @@ async def fetch(self, limit: int) -> list[JobRunningPipelineItem]:
),
or_(
and_(
# Do not try to lock jobs if the run is waiting for the lock,
# Do not try to lock jobs if the run is waiting for the lock or terminating,
# but allow retrying jobs whose own lock is stale because
# the run pipeline cannot reclaim stale job locks.
RunModel.lock_owner.is_(None),
RunModel.status.not_in([RunStatus.TERMINATING]),
JobModel.lock_expires_at.is_(None),
),
JobModel.lock_expires_at < now,
Expand Down
Loading