Update KemonopartyParser.js#2085
Closed
Kiradien wants to merge 2 commits into
Closed
Conversation
Fix Cover Image detection on Load&Analyze referenced in dteviot#2064
Collaborator
|
@Kiradien i catch such errors in the update all function from the library as they happen often. To ignore them as the cover, author etc. aren't needed if you are just updating an existing story. |
Collaborator
Author
|
I'll close the PR and leave it here then; honestly don't see it likely people will 'load and analyze' that site. |
Collaborator
|
@Kiradien agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Cover Image detection on Load&Analyze referenced in #2064
Not sure if we actually want this; Load & Analyze was throwing errors, though.