(pre-flight check) Improve error message (operator-framework#2006)

anik120 · web-flow · commit 0c9f0b529d50 · 2025-06-11T15:34:12.000-04:00
The line "failed to get release state using client-only dry-run" is too
jargon heavy, and meaningless for the end user.
This PR replaces the error message with a more user friendly text.
diff --git a/internal/operator-controller/applier/helm.go b/internal/operator-controller/applier/helm.go
@@ -91,7 +91,7 @@ func shouldSkipPreflight(ctx context.Context, preflight Preflight, ext *ocv1.Clu
 func (h *Helm) runPreAuthorizationChecks(ctx context.Context, ext *ocv1.ClusterExtension, chart *chart.Chart, values chartutil.Values, post postrender.PostRenderer) error {
 	tmplRel, err := h.renderClientOnlyRelease(ctx, ext, chart, values, post)
 	if err != nil {
-		return fmt.Errorf("failed to get release state using client-only dry-run: %w", err)
+		return fmt.Errorf("error rendering content for pre-authorization checks: %w", err)
 	}
 
 	missingRules, authErr := h.PreAuthorizer.PreAuthorize(ctx, ext, strings.NewReader(tmplRel.Manifest))

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func shouldSkipPreflight(ctx context.Context, preflight Preflight, ext *ocv1.Clu`
`91`	`91`	`func (h Helm) runPreAuthorizationChecks(ctx context.Context, ext ocv1.ClusterExtension, chart *chart.Chart, values chartutil.Values, post postrender.PostRenderer) error {`
`92`	`92`	`tmplRel, err := h.renderClientOnlyRelease(ctx, ext, chart, values, post)`
`93`	`93`	`if err != nil {`
`94`		`- return fmt.Errorf("failed to get release state using client-only dry-run: %w", err)`
	`94`	`+ return fmt.Errorf("error rendering content for pre-authorization checks: %w", err)`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`missingRules, authErr := h.PreAuthorizer.PreAuthorize(ctx, ext, strings.NewReader(tmplRel.Manifest))`