Skip to content

Commit 542ac9c

Browse files
authored
fix: Add the missing jackson annotations to SignalRequest (#1452)
1 parent 4e30916 commit 542ac9c

2 files changed

Lines changed: 23 additions & 3 deletions

File tree

portability-spi-transfer/src/main/java/org/datatransferproject/spi/transfer/provider/SignalRequest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,27 @@
1616

1717
package org.datatransferproject.spi.transfer.provider;
1818

19+
import com.fasterxml.jackson.annotation.JsonProperty;
1920
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2021
import com.google.auto.value.AutoValue;
2122
import org.datatransferproject.spi.transfer.types.signals.JobLifeCycle;
2223

2324
@AutoValue
2425
@JsonDeserialize(builder = SignalRequest.Builder.class)
2526
public abstract class SignalRequest {
27+
@JsonProperty("jobId")
2628
public abstract String jobId();
29+
30+
@JsonProperty("dataType")
2731
public abstract String dataType();
32+
33+
@JsonProperty("jobStatus")
2834
public abstract JobLifeCycle jobStatus();
35+
36+
@JsonProperty("exportingService")
2937
public abstract String exportingService();
38+
39+
@JsonProperty("importingService")
3040
public abstract String importingService();
3141

3242
public static Builder builder() {

portability-spi-transfer/src/main/java/org/datatransferproject/spi/transfer/types/signals/JobLifeCycle.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
package org.datatransferproject.spi.transfer.types.signals;
22

3+
import com.fasterxml.jackson.annotation.JsonProperty;
4+
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
35
import com.google.auto.value.AutoValue;
46
import com.google.common.base.Preconditions;
57
import javax.annotation.Nullable;
8+
9+
import org.datatransferproject.spi.transfer.provider.SignalRequest;
610
import org.datatransferproject.spi.transfer.types.FailureReasons;
711

812
/**
@@ -11,22 +15,28 @@
1115
* granular states + reasons.
1216
*/
1317
@AutoValue
18+
@JsonDeserialize(builder = JobLifeCycle.Builder.class)
1419
public abstract class JobLifeCycle {
1520
public static Builder builder() {
1621
return new org.datatransferproject.spi.transfer.types.signals.AutoValue_JobLifeCycle.Builder()
17-
.setState(State.UNKNOWN_STATE);
22+
.setState(State.UNKNOWN_STATE);
1823
}
1924

25+
@JsonProperty("state")
2026
public abstract State state();
27+
2128
@Nullable
29+
@JsonProperty("failureReason")
2230
public abstract FailureReasons failureReason();
31+
2332
@Nullable
33+
@JsonProperty("endReason")
2434
public abstract EndReason endReason();
2535

2636
public static JobLifeCycle JOB_STARTED() {
2737
return JobLifeCycle.builder()
28-
.setState(JobLifeCycle.State.STARTED)
29-
.build();
38+
.setState(JobLifeCycle.State.STARTED)
39+
.build();
3040
}
3141

3242
@AutoValue.Builder

0 commit comments

Comments
 (0)