feat: add SynologySignalHandler to Synology transfer extension#1484
Merged
mengyushen merged 1 commit intoMar 13, 2026
Merged
Conversation
Implemented SynologySignalHandler to manage job lifecycle signals (e.g., job completion or failure). - Added SynologySignalHandler to handle and retry job lifecycle signals. - Added sendJobSignal to SynologyDTPService to communicate with the Synology C2 API. - Updated SynologyTransferExtension to register the new signal handler. - Configured the new /import/job/signal endpoint in synology.yaml. - Added SynologySignalHandlerTest to verify signal sending and retry logic.
mengyushen
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
SynologySignalHandlerto manage job lifecycle signals (e.g., job started or completion) within the Synology transfer extension. This ensures that the Synology C2 API is notified of the final state of a transfer job, allowing for better synchronization.Changes
SynologySignalHandlerto process and retry job lifecycle signals using theRetryingCallable framework.
sendJobSignaltoSynologyDTPServiceto handle the actual HTTP POST request to theSynology C2 API.
SynologyTransferExtensionto register the new SignalHandler during initialization.synology.yamlto include the new/import/job/signalendpoint.C2Apiand itsApiPathinner class to support the new signal path.SynologySignalHandlerTestto verify successful signal transmission and the retry mechanism on failure.TestConfigsto include the signal path for existing tests.