feat(synology): implement streaming for large file uploads#1485
Merged
mengyushen merged 2 commits intoMar 18, 2026
Conversation
Key changes: - Implemented streaming uploads using Okio and a custom RequestBody. - Introduced RequestBodyGenerator to support retries by re-opening streams. - Refactored stream retrieval into getMediaInputStreamWrapper. - Added SynologyDTPServiceOOMTest to verify 1GB+ uploads without OOM.
simonxander
force-pushed
the
synology-large-file-upload
branch
from
d2c21d2 to
4745bc8
Compare
mengyushen
approved these changes
Mar 17, 2026
Reviewer: amychen Ref: dlt1/data-transfer-project#15
Collaborator
|
Looks Good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this change is to support large file uploads for
SynologyDTPServiceby implementing streaming. This resolves potential OutOfMemoryError (OOM) issues that occurred when large media files were fully buffered into memory during the transfer process.Changes
ByteStreams.toByteArray()with a customRequestBodyimplementation using Okio to stream data directly from the source (JobStoreorURL) to the network sink.RequestBodyGenerator, a functional interface that allows thesendPostRequestmethod to re-open theInputStreamduring retries. This ensures that even if a stream is consumed during a failed attempt, it can be reset for the next retry.Testing
SynologyDTPServiceOOMTestto verify 1GB streaming.SynologyDTPServiceTestto accommodate the newRequestBodyGeneratorpattern and added cases forgetMediaInputStreamWrapper.