Resolve unnecessary_map_or clippy lint

    warning: this `map_or` can be simplified
      --> build.rs:76:38
       |
    76 |     if cfg!(not(feature = "std")) && rustc.map_or(false, |rustc| rustc < 81) {
       |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
       = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all`
       = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`
    help: use `is_some_and` instead
       |
    76 -     if cfg!(not(feature = "std")) && rustc.map_or(false, |rustc| rustc < 81) {
    76 +     if cfg!(not(feature = "std")) && rustc.is_some_and(|rustc| rustc < 81) {
       |

    warning: this `map_or` can be simplified
       --> impl/src/expand.rs:385:13
        |
    385 | /             v.attrs
    386 | |                 .display
    387 | |                 .as_ref()
    388 | |                 .map_or(false, |display| display.has_bonus_display)
        | |___________________________________________________________________^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
        = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all`
        = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`
    help: use `is_some_and` instead
        |
    388 -                 .map_or(false, |display| display.has_bonus_display)
    388 +                 .is_some_and(|display| display.has_bonus_display)
        |

    warning: this `map_or` can be simplified
       --> impl/src/prop.rs:131:8
        |
    131 |       if from_field.map_or(false, |from_field| {
        |  ________^
    132 | |         from_field.member == backtrace_field.member
    133 | |     }) {
        | |______^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    help: use `is_some_and` instead
        |
    131 -     if from_field.map_or(false, |from_field| {
    131 +     if from_field.is_some_and(|from_field| {
        |

    warning: this `map_or` can be simplified
       --> impl/src/valid.rs:242:32
        |
    242 |           Type::Reference(ty) => ty
        |  ________________________________^
    243 | |             .lifetime
    244 | |             .as_ref()
    245 | |             .map_or(false, |lifetime| lifetime.ident != "static"),
        | |_________________________________________________________________^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    help: use `is_some_and` instead
        |
    245 -             .map_or(false, |lifetime| lifetime.ident != "static"),
    245 +             .is_some_and(|lifetime| lifetime.ident != "static"),
        |

Author: dtolnay

build.rs

@@ -73,7 +73,7 @@ fn main() {
     // core::error::Error stabilized in Rust 1.81
     // https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#coreerrorerror
     let rustc = rustc_minor_version();
-    if cfg!(not(feature = "std")) && rustc.map_or(false, |rustc| rustc < 81) {
+    if cfg!(not(feature = "std")) && rustc.is_some_and(|rustc| rustc < 81) {
         println!("cargo:rustc-cfg=feature=\"std\"");
     }
 

impl/src/expand.rs

@@ -385,7 +385,7 @@ fn impl_enum(input: Enum) -> TokenStream {
             v.attrs
                 .display
                 .as_ref()
-                .map_or(false, |display| display.has_bonus_display)
+                .is_some_and(|display| display.has_bonus_display)
         });
         let use_as_display = use_as_display(has_bonus_display);
         let void_deref = if input.variants.is_empty() {

impl/src/prop.rs

@@ -128,9 +128,7 @@ fn distinct_backtrace_field<'a, 'b>(
     backtrace_field: &'a Field<'b>,
     from_field: Option<&Field>,
 ) -> Option<&'a Field<'b>> {
-    if from_field.map_or(false, |from_field| {
-        from_field.member == backtrace_field.member
-    }) {
+    if from_field.is_some_and(|from_field| from_field.member == backtrace_field.member) {
         None
     } else {
         Some(backtrace_field)

impl/src/valid.rs

@@ -242,7 +242,7 @@ fn contains_non_static_lifetime(ty: &Type) -> bool {
         Type::Reference(ty) => ty
             .lifetime
             .as_ref()
-            .map_or(false, |lifetime| lifetime.ident != "static"),
+            .is_some_and(|lifetime| lifetime.ident != "static"),
         _ => false, // maybe implement later if there are common other cases
     }
 }