Skip to content

Commit ad0ee6b

Browse files
committed
pythongh-90369: change test server threads to joinable
These were made daemons in an otherwise unrelated commit. The test code that joins them was not deleted and still works, so they can just be made joinable again.
1 parent 2b0c684 commit ad0ee6b

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

Lib/test/test_ftplib.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ class DummyFTPServer(asyncore.dispatcher, threading.Thread):
283283
def __init__(self, address, af=socket.AF_INET, encoding=DEFAULT_ENCODING):
284284
threading.Thread.__init__(self)
285285
asyncore.dispatcher.__init__(self)
286-
self.daemon = True
287286
self.create_socket(af, socket.SOCK_STREAM)
288287
self.bind(address)
289288
self.listen(5)
@@ -1052,7 +1051,6 @@ def setUp(self):
10521051
self.sock.settimeout(20)
10531052
self.port = socket_helper.bind_port(self.sock)
10541053
self.server_thread = threading.Thread(target=self.server)
1055-
self.server_thread.daemon = True
10561054
self.server_thread.start()
10571055
# Wait for the server to be ready.
10581056
self.evt.wait()

Lib/test/test_poplib.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ class DummyPOP3Server(asyncore.dispatcher, threading.Thread):
211211
def __init__(self, address, af=socket.AF_INET):
212212
threading.Thread.__init__(self)
213213
asyncore.dispatcher.__init__(self)
214-
self.daemon = True
215214
self.create_socket(af, socket.SOCK_STREAM)
216215
self.bind(address)
217216
self.listen(5)

0 commit comments

Comments
 (0)