CURLOPT_ACCEPT_ENCODING set to NULL#263
Merged
Merged
Conversation
Member
Author
|
Relevant in the context of duckdb/duckdb#20977 |
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Feb 26, 2026
lnkuiper
pushed a commit
to duckdb/duckdb
that referenced
this pull request
Feb 27, 2026
Contributor
|
Hi, this PR has caused some problems with me and I just opened an issue to re-enable cURL's support for Content-Encoding. With this change no responses are compressed with gzip/deflate and we're using more bandwidth than we need. But even worse, if I want to handle the decompression myself in an extension, now when the server sends |
Contributor
|
PR is #278 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant documentation at https://curl.se/libcurl/c/CURLOPT_ACCEPT_ENCODING.html
I am considering whether having an option (that can be set user side), would be best here in case of regressions.
Fix was proposed by @ywelsch in the context of wider testing they performed where files uploaded to S3 like:
would be unzipped twice since information is not propagated between layers.