fix for msvc

Author: evertlammerts

src/duckdb_py/arrow/arrow_array_stream.cpp

@@ -188,7 +188,8 @@ unique_ptr<ArrowArrayStreamWrapper> PythonTableArrowArrayStreamFactory::Produce(
 		break;
 	}
 	default: {
-		auto py_object_type = py::cast<std::string>(py::str((arrow_obj_handle).type().attr("__name__")));
+		// py::object wrap: py::str() of a bare .attr() accessor is an ambiguous overload on MSVC.
+		auto py_object_type = py::cast<std::string>(py::str(py::object((arrow_obj_handle).type().attr("__name__"))));
 		throw InvalidInputException("Object of type '%s' is not a recognized Arrow object", py_object_type);
 	}
 	}

src/duckdb_py/native/python_objects.cpp

@@ -45,15 +45,16 @@ interval_t PyTimeDelta::ToInterval() {
 }
 
 int64_t PyTimeDelta::GetDays(py::handle &obj) {
-	return py::cast<int64_t>(py::int_(obj.attr("days")));
+	// py::object wrap: py::int_() of a bare .attr() accessor is an ambiguous overload on MSVC.
+	return py::cast<int64_t>(py::int_(py::object(obj.attr("days"))));
 }
 
 int64_t PyTimeDelta::GetSeconds(py::handle &obj) {
-	return py::cast<int64_t>(py::int_(obj.attr("seconds")));
+	return py::cast<int64_t>(py::int_(py::object(obj.attr("seconds"))));
 }
 
 int64_t PyTimeDelta::GetMicros(py::handle &obj) {
-	return py::cast<int64_t>(py::int_(obj.attr("microseconds")));
+	return py::cast<int64_t>(py::int_(py::object(obj.attr("microseconds"))));
 }
 
 PyDecimal::PyDecimal(py::handle &obj) : obj(obj) {

src/duckdb_py/pyconnection.cpp

@@ -339,7 +339,8 @@ void DuckDBPyConnection::RegisterFilesystem(py::object filesystem) {
 
 	auto &fs = database.GetFileSystem();
 
-	auto protocol = filesystem.attr("protocol");
+	// py::object (not auto, which deduces an accessor): py::str(protocol) below is an ambiguous overload on MSVC.
+	py::object protocol = filesystem.attr("protocol");
 	if (protocol.is_none() || py::str("abstract").equal(protocol)) {
 		throw InvalidInputException("Must provide concrete fsspec implementation");
 	}
@@ -1843,7 +1844,8 @@ std::unique_ptr<DuckDBPyRelation> DuckDBPyConnection::FromArrow(py::object &arro
 	auto &connection = con.GetConnection();
 	string name = "arrow_object_" + StringUtil::GenerateRandomName();
 	if (!IsAcceptedArrowObject(arrow_object)) {
-		auto py_object_type = py::cast<std::string>(py::str((arrow_object).type().attr("__name__")));
+		// py::object wrap: py::str() of a bare .attr() accessor is an ambiguous overload on MSVC.
+		auto py_object_type = py::cast<std::string>(py::str(py::object((arrow_object).type().attr("__name__"))));
 		throw InvalidInputException("Python Object Type %s is not an accepted Arrow Object.", py_object_type);
 	}
 	auto tableref = PythonReplacementScan::ReplacementObject(arrow_object, name, *connection.context, true);

src/duckdb_py/python_replacement_scan.cpp

@@ -86,7 +86,8 @@ static void CreateArrowScan(const string &name, py::object entry, TableFunctionR
 
 static void ThrowScanFailureError(const py::object &entry, const string &name, const string &location = "") {
 	string error;
-	auto py_object_type = py::cast<std::string>(py::str((entry).type().attr("__name__")));
+	// py::object wrap: py::str() of a bare .attr() accessor is an ambiguous overload on MSVC.
+	auto py_object_type = py::cast<std::string>(py::str(py::object((entry).type().attr("__name__"))));
 	error += StringUtil::Format("Python Object \"%s\" of type \"%s\"", name, py_object_type);
 	if (!location.empty()) {
 		error += StringUtil::Format(" found on line \"%s\"", location);

src/duckdb_py/typing/pytype.cpp

@@ -261,7 +261,8 @@ static LogicalType FromGenericAlias(const py::object &obj) {
 	py::module_ types = py::module_::import_("types");
 	auto generic_alias = types.attr("GenericAlias");
 	D_ASSERT(py::isinstance(obj, generic_alias));
-	auto origin = obj.attr("__origin__");
+	// py::object (not auto, which deduces an accessor): py::str(accessor) is an ambiguous overload on MSVC.
+	py::object origin = obj.attr("__origin__");
 	py::tuple args = obj.attr("__args__");
 
 	if (origin.is(builtins.attr("list"))) {