Rename to TryEnsurePathString and EnsurePathString

Author: leostimpfle

src/include/duckdb_python/path_like.hpp

@@ -9,8 +9,8 @@ namespace duckdb {
 
 struct DuckDBPyConnection;
 
-bool TryDecodePath(const nb::object &object, string &result);
-string PathToString(const nb::object &object);
+bool TryEnsurePathString(const nb::object &object, string &result);
+string EnsurePathString(const nb::object &object);
 
 struct PathLike {
 	static PathLike Create(const nb::object &object, DuckDBPyConnection &connection);

src/path_like.cpp

@@ -34,7 +34,7 @@ struct PathLikeProcessor {
 	vector<string> fs_files;
 };
 
-bool TryDecodePath(const nb::object &object, string &result) {
+bool TryEnsurePathString(const nb::object &object, string &result) {
 	if (nb::isinstance<nb::str>(object)) {
 		result = nb::cast<string>(object);
 		return true;
@@ -48,9 +48,9 @@ bool TryDecodePath(const nb::object &object, string &result) {
 	return false;
 }
 
-string PathToString(const nb::object &object) {
+string EnsurePathString(const nb::object &object) {
 	string result;
-	if (!TryDecodePath(object, result)) {
+	if (!TryEnsurePathString(object, result)) {
 		throw InvalidInputException("Expected a str, bytes, or os.PathLike object for the file path, not '%s'",
 		                            Py_TYPE(object.ptr())->tp_name);
 	}
@@ -59,7 +59,7 @@ string PathToString(const nb::object &object) {
 
 void PathLikeProcessor::AddFile(const nb::object &object) {
 	string decoded;
-	if (TryDecodePath(object, decoded)) {
+	if (TryEnsurePathString(object, decoded)) {
 		all_files.push_back(std::move(decoded));
 		return;
 	}

src/pyrelation.cpp

@@ -1261,7 +1261,7 @@ void DuckDBPyRelation::ToParquet(const nb::object &file_name, const nb::object &
                                  const nb::object &partition_by, const nb::object &write_partition_columns,
                                  const nb::object &append, const nb::object &filename_pattern,
                                  const nb::object &file_size_bytes) {
-	auto filename = PathToString(file_name);
+	auto filename = EnsurePathString(file_name);
 	case_insensitive_map_t<vector<Value>> options;
 
 	if (!nb::none().is(compression)) {
@@ -1381,7 +1381,7 @@ void DuckDBPyRelation::ToCSV(const nb::object &file_name, const nb::object &sep,
                              const nb::object &overwrite, const nb::object &per_thread_output,
                              const nb::object &use_tmp_file, const nb::object &partition_by,
                              const nb::object &write_partition_columns) {
-	auto filename = PathToString(file_name);
+	auto filename = EnsurePathString(file_name);
 	case_insensitive_map_t<vector<Value>> options;
 
 	if (!nb::none().is(sep)) {