Skip to content

Fix and conform Spark API's show() and UDF register(). #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shooter23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix and conform Spark API's show() and UDF register(). #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f1895
Fix and conform Spark API's show() and UDF register().
Shooter23 Jul 18, 2026
e019450
Merge branch 'main' into main
Shooter23 Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions duckdb/experimental/spark/sql/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,26 @@ def __init__(self, relation: duckdb.DuckDBPyRelation, session: "SparkSession") -
if self.relation is not None:
self._schema = duckdb_to_spark_schema(self.relation.columns, self.relation.types)

def show(self, **kwargs) -> None: # noqa: D102
self.relation.show()
def show(
self,
n: int = 20,
truncate: Union[bool, int] = True,
vertical: bool = False,
) -> None: # noqa: D102
if isinstance(truncate, int):
max_col_width = truncate
elif truncate:
max_col_width = 20
else:
max_col_width = 9999

render_mode = 'COLUMNS' if vertical else None

self.relation.show(
max_rows=n,
max_col_width=max_col_width,
render_mode=render_mode
)

def toPandas(self) -> "PandasDataFrame": # noqa: D102
return self.relation.df()
Expand Down
8 changes: 7 additions & 1 deletion duckdb/experimental/spark/sql/udf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ def register( # noqa: D102
f: "Callable[..., Any] | UserDefinedFunctionLike",
returnType: Optional["DataTypeOrString"] = None,
) -> "UserDefinedFunctionLike":
self.sparkSession.conn.create_function(name, f, return_type=returnType)
self.sparkSession.conn.create_function(
name,
f,
None,
return_type=returnType.duckdb_type if returnType else None,
null_handling='special',
)

def registerJavaFunction( # noqa: D102
self,
Expand Down