Split DuckAiChatStore.setPinned into pinChat / unpinChat

Intent-named methods read more naturally at call sites that already
know which direction they're going, and dropping the Boolean return
keeps the public contract free of JSON-validity concerns — not-found
and malformed JSON are silent no-ops. The shared mutation logic stays
as a private setPinned helper inside RealDuckAiChatStore.

The repository keeps its boolean-toggle setPinned signature because
its caller (ChatHistoryViewModel) computes the next state as a
boolean; the impl dispatches to pinChat / unpinChat.

Author: GerardPaligot

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/history/ChatHistoryRepository.kt

@@ -65,7 +65,9 @@ class RealChatHistoryRepository @Inject constructor(
         withContext(dispatchers.io()) { chatStore.renameChat(chatId, newTitle) }
 
     override suspend fun setPinned(chatId: String, pinned: Boolean) {
-        withContext(dispatchers.io()) { chatStore.setPinned(chatId, pinned) }
+        withContext(dispatchers.io()) {
+            if (pinned) chatStore.pinChat(chatId) else chatStore.unpinChat(chatId)
+        }
     }
 
     private fun toChatHistoryItem(chat: DuckAiChat): ChatHistoryItem = ChatHistoryItem(

duckchat/duckchat-store/src/main/java/com/duckduckgo/duckchat/store/impl/RealDuckAiChatStore.kt

@@ -67,8 +67,11 @@ interface DuckAiChatStore {
     /** Renames [chatId] in the FE-owned JSON blob. Returns true if the chat existed and was updated, false otherwise. */
     suspend fun renameChat(chatId: String, newTitle: String): Boolean
 
-    /** Sets the pinned flag on [chatId]. Returns true if the chat existed and was updated, false otherwise. */
-    suspend fun setPinned(chatId: String, pinned: Boolean): Boolean
+    /** Pins [chatId]. Silent no-op if the chat is not found or the stored JSON is malformed. */
+    suspend fun pinChat(chatId: String)
+
+    /** Unpins [chatId]. Silent no-op if the chat is not found or the stored JSON is malformed. */
+    suspend fun unpinChat(chatId: String)
 }
 
 @SingleInstanceIn(AppScope::class)
@@ -146,16 +149,20 @@ class RealDuckAiChatStore @Inject constructor(
             true
         }
 
-    override suspend fun setPinned(chatId: String, pinned: Boolean): Boolean =
+    override suspend fun pinChat(chatId: String) = setPinned(chatId, pinned = true)
+
+    override suspend fun unpinChat(chatId: String) = setPinned(chatId, pinned = false)
+
+    private suspend fun setPinned(chatId: String, pinned: Boolean) {
         withContext(dispatchers.io()) {
             logcat { "DuckAI: RealDuckAiChatStore.setPinned($chatId, $pinned)" }
-            val entity = chatsDao.getById(chatId) ?: return@withContext false
+            val entity = chatsDao.getById(chatId) ?: return@withContext
             val updatedJson = runCatching {
                 JSONObject(entity.data).put("pinned", pinned).toString()
-            }.getOrNull() ?: return@withContext false
+            }.getOrNull() ?: return@withContext
             chatsDao.upsert(entity.copy(data = updatedJson))
-            true
         }
+    }
 
     private fun DuckAiBridgeChatEntity.toDuckAiChat(): DuckAiChat? = runCatching {
         val json = JSONObject(data)

duckchat/duckchat-store/src/test/kotlin/com/duckduckgo/duckchat/store/impl/RealDuckAiChatStoreTest.kt

@@ -337,24 +337,25 @@ class RealDuckAiChatStoreTest {
         verify(chatsDao).deleteAll()
     }
 
-    // --- setPinned ---
+    // --- pinChat / unpinChat ---
 
     @Test
-    fun `setPinned returns false when chat not found`() = runTest {
+    fun `pinChat is a no-op when chat not found`() = runTest {
         whenever(chatsDao.getById("missing")).thenReturn(null)
 
-        assertFalse(store.setPinned("missing", true))
+        store.pinChat("missing")
+
         verify(chatsDao, never()).upsert(any())
     }
 
     @Test
-    fun `setPinned updates only the pinned flag and preserves other JSON fields`() = runTest {
+    fun `pinChat sets pinned to true and preserves other JSON fields`() = runTest {
         val originalJson = """
             {"chatId":"abc","title":"Old","model":"gpt-5-mini","lastEdit":"2026-04-01T21:31:54.260Z","pinned":false,"fileRefs":["uuid1"],"messages":[{"role":"user","text":"hi"}]}
         """.trimIndent()
         whenever(chatsDao.getById("abc")).thenReturn(DuckAiBridgeChatEntity("abc", originalJson))
 
-        assertTrue(store.setPinned("abc", true))
+        store.pinChat("abc")
 
         val entityCaptor = argumentCaptor<DuckAiBridgeChatEntity>()
         verify(chatsDao).upsert(entityCaptor.capture())
@@ -369,10 +370,26 @@ class RealDuckAiChatStoreTest {
     }
 
     @Test
-    fun `setPinned returns false when stored JSON is malformed`() = runTest {
+    fun `unpinChat sets pinned to false`() = runTest {
+        val originalJson = """
+            {"chatId":"abc","title":"Old","model":"gpt-5-mini","lastEdit":"2026-04-01T21:31:54.260Z","pinned":true}
+        """.trimIndent()
+        whenever(chatsDao.getById("abc")).thenReturn(DuckAiBridgeChatEntity("abc", originalJson))
+
+        store.unpinChat("abc")
+
+        val entityCaptor = argumentCaptor<DuckAiBridgeChatEntity>()
+        verify(chatsDao).upsert(entityCaptor.capture())
+        val json = JSONObject(entityCaptor.firstValue.data)
+        assertFalse(json.getBoolean("pinned"))
+    }
+
+    @Test
+    fun `pinChat is a no-op when stored JSON is malformed`() = runTest {
         whenever(chatsDao.getById("abc")).thenReturn(DuckAiBridgeChatEntity("abc", "not a json"))
 
-        assertFalse(store.setPinned("abc", true))
+        store.pinChat("abc")
+
         verify(chatsDao, never()).upsert(any())
     }
 }