Skip to content

Commit 070c159

Browse files
authored
resolve remaining E2E tests conflicts for onboarding brand design update (#8716)
Task/Issue URL: https://app.asana.com/1/137249556945/project/414730916066338/task/1215224683059972?focus=true ### Description Resolves remaining E2E tests conflicts for onboarding brand design update. ### Steps to test this PR QA optional, verified locally via: ```bash maestro test .maestro/onboarding/ ``` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only Maestro YAML changes with no production code impact. > > **Overview** > Updates **Maestro** onboarding and fire-button flows so dismiss taps and visibility checks work with the new onboarding brand design. > > Dismiss controls now target **`daxDialogDismissButton|brandDesignDismissButton`** on the initial dialog and **`daxDialogDismissButton|contextualBrandDesignDismissButton`** on later contextual dialogs, so tests pass whether the old or new dismiss control is shown. > > The “creepy ad loses its wings” copy assertion uses a looser regex (**`its.wings`**) to match possible spacing or line-break changes in the updated UI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 05b36af. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent fcfc3f7 commit 070c159

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

.maestro/fire_button/dimiss_fire_during_onboarding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ tags:
2323
- assertVisible:
2424
text: ".*browsing activity with the fire button.*"
2525
- tapOn:
26-
id: daxDialogDismissButton
26+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
2727
- assertNotVisible:
2828
text: ".*browsing activity with the Fire Button.*"

.maestro/onboarding/onboarding_dismiss_all_dialogs.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@ tags:
1212
clearState: true
1313
- runFlow: ../shared/pre_onboarding.yaml
1414
- assertVisible:
15-
id: daxDialogDismissButton
15+
id: "daxDialogDismissButton|brandDesignDismissButton"
1616
- tapOn:
17-
id: daxDialogDismissButton
17+
id: "daxDialogDismissButton|brandDesignDismissButton"
1818
- assertVisible:
1919
id: ddgLogo
2020
- inputText: "https://www.search-company.site/#ad-id-14"
2121
- pressKey: Enter
2222
- assertVisible:
2323
text: ".*As you tap and scroll, I'll block pesky trackers..*"
2424
- assertVisible:
25-
id: daxDialogDismissButton
25+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
2626
- tapOn:
27-
id: daxDialogDismissButton
27+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
2828
- assertNotVisible:
2929
text: ".*As you tap and scroll, I'll block pesky trackers..*"
3030
- assertVisible:
@@ -34,23 +34,23 @@ tags:
3434
- assertVisible:
3535
text: ".*was trying to track you here. I blocked them!.*"
3636
- assertVisible:
37-
id: daxDialogDismissButton
37+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
3838
- tapOn:
39-
id: daxDialogDismissButton
39+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
4040
- assertNotVisible:
4141
text: ".*was trying to track you here. I blocked them!.*"
4242
- assertVisible:
4343
text: "Publisher site"
4444
- tapOn:
4545
text: "Publisher site"
4646
- assertVisible:
47-
text: ".*Remember: every time you browse with me a creepy ad loses its wings..*"
47+
text: ".*Remember: every time you browse with me a creepy ad loses its.wings..*"
4848
- assertVisible:
49-
id: daxDialogDismissButton
49+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
5050
- tapOn:
51-
id: daxDialogDismissButton
51+
id: "daxDialogDismissButton|contextualBrandDesignDismissButton"
5252
- assertNotVisible:
53-
text: ".*Remember: every time you browse with me a creepy ad loses its wings..*"
53+
text: ".*Remember: every time you browse with me a creepy ad loses its.wings..*"
5454
- runFlow: ../shared/browser_screen/click_on_tabs_button.yaml
5555
- tapOn: "New Tab"
5656
- assertVisible:

.maestro/onboarding/onboarding_dismiss_try_a_search_dialog.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ tags:
1212
clearState: true
1313
- runFlow: ../shared/pre_onboarding.yaml
1414
- assertVisible:
15-
id: daxDialogDismissButton
15+
id: "daxDialogDismissButton|brandDesignDismissButton"
1616
- tapOn:
17-
id: daxDialogDismissButton
17+
id: "daxDialogDismissButton|brandDesignDismissButton"
1818
- assertVisible:
1919
id: ddgLogo

0 commit comments

Comments
 (0)