Commit 070c159
authored
resolve remaining E2E tests conflicts for onboarding brand design update (#8716)
Task/Issue URL:
https://app.asana.com/1/137249556945/project/414730916066338/task/1215224683059972?focus=true
### Description
Resolves remaining E2E tests conflicts for onboarding brand design
update.
### Steps to test this PR
QA optional, verified locally via:
```bash
maestro test .maestro/onboarding/
```
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Test-only Maestro YAML changes with no production code impact.
>
> **Overview**
> Updates **Maestro** onboarding and fire-button flows so dismiss taps
and visibility checks work with the new onboarding brand design.
>
> Dismiss controls now target
**`daxDialogDismissButton|brandDesignDismissButton`** on the initial
dialog and
**`daxDialogDismissButton|contextualBrandDesignDismissButton`** on later
contextual dialogs, so tests pass whether the old or new dismiss control
is shown.
>
> The “creepy ad loses its wings” copy assertion uses a looser regex
(**`its.wings`**) to match possible spacing or line-break changes in the
updated UI.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
05b36af. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent fcfc3f7 commit 070c159
3 files changed
Lines changed: 13 additions & 13 deletions
File tree
- .maestro
- fire_button
- onboarding
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
0 commit comments