Commit 0f9da8a
Fire Mode: WebView profile management (#8575)
Task/Issue URL:
https://app.asana.com/1/137249556945/project/1207418217763355/task/1214780084779090?focus=true
### Description
Isolates WebView state between Regular and Fire browser modes via
AndroidX webkit's `MULTI_PROFILE` API. Each newly-created `WebView` is
bound to its mode-specific `androidx.webkit.Profile` so cookies,
LocalStorage, IndexedDB, and other origin-keyed storage are partitioned
per mode. No-op on devices without MultiProfile support.
Pieces introduced:
- **`WebViewModeInitializer`** (`browser-mode-api`) — binds a
freshly-created `WebView` to the profile for a given `BrowserMode`.
`BrowserTabFragment` injects it and calls `bind(it, browserMode)` inside
`configureWebView()` immediately after inflating the
`DuckDuckGoWebView`, before any settings or clients are applied.
- **`WebStorageProvider`** (`BrowserModeDataProvider<WebStorage>`) —
resolves the per-mode `WebStorage` via `ProfileStore`, falling back to
the shared default `WebStorage` when MultiProfile is unavailable.
- **`BrowserMode.profileName`** extension — stable mapping from mode to
profile name (`REGULAR` → default profile, `FIRE` → `"Fire"`).
- **`FireModeAvailability`** is now synchronous (`fun isAvailable()`),
uses `WebViewFeature.MULTI_PROFILE` directly instead of
`WebViewCapabilityChecker`, warms its cache on main-process `onCreate`
via `MainProcessLifecycleObserver`, and freezes the first computed value
so later flag flips don't change the answer mid-session.
API proposal: [WebViewModeInitializer
interface](https://app.asana.com/1/137249556945/project/1207418217763355/task/1214944190409737?focus=true)
### Steps to test this PR
- [x] Smoke test the app and make sure data-clearing works as before.
There should be no change to any user-visible functionality
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes WebView creation and session storage partitioning at tab open;
Fire tabs can be closed if profile binding fails, but Regular mode and
devices without MultiProfile should behave as before when binding is
skipped or falls back.
>
> **Overview**
> Introduces **WebView multi-profile** wiring so Regular and Fire tabs
use separate AndroidX WebView profiles (cookies, LocalStorage,
IndexedDB, etc.), with no binding when `MULTI_PROFILE` is unsupported.
>
> **`WebViewModeInitializer`** binds each new `WebView` to the profile
for the tab’s `BrowserMode` (via **`BrowserMode.profileName`**) before
any other WebView setup. **`BrowserTabFragment`** calls it right after
inflation; if binding fails in a non-Regular mode, it logs, **closes the
tab**, and tears down the WebView.
>
> **`WebStorageProvider`** implements
**`BrowserModeDataProvider<WebStorage>`**, returning profile-scoped
storage when Fire/multi-profile is available, otherwise the shared
default.
>
> **`FireModeAvailability`** is now synchronous, checks
**`WebViewFeature.MULTI_PROFILE`** directly (replacing
**`WebViewCapabilityChecker`**), warms availability on main-process
**`onCreate`**, and **freezes** the first computed result for the
session.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
513ec83. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>1 parent f3c9eb8 commit 0f9da8a
10 files changed
Lines changed: 412 additions & 45 deletions
File tree
- app/src
- main/java/com/duckduckgo/app/browser
- mode
- test/java/com/duckduckgo/app/browser/mode
- browser-mode
- browser-mode-api/src/main/java/com/duckduckgo/browsermode/api
- browser-mode-impl/src
- main/java/com/duckduckgo/browsermode/impl
- test/kotlin/com/duckduckgo/browsermode/impl
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| 276 | + | |
276 | 277 | | |
277 | 278 | | |
278 | 279 | | |
| |||
441 | 442 | | |
442 | 443 | | |
443 | 444 | | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
444 | 448 | | |
445 | 449 | | |
446 | 450 | | |
| |||
3991 | 3995 | | |
3992 | 3996 | | |
3993 | 3997 | | |
| 3998 | + | |
| 3999 | + | |
| 4000 | + | |
| 4001 | + | |
| 4002 | + | |
| 4003 | + | |
| 4004 | + | |
| 4005 | + | |
| 4006 | + | |
| 4007 | + | |
| 4008 | + | |
| 4009 | + | |
| 4010 | + | |
3994 | 4011 | | |
3995 | 4012 | | |
3996 | 4013 | | |
| |||
Lines changed: 57 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
browser-mode/browser-mode-api/src/main/java/com/duckduckgo/browsermode/api/FireModeAvailability.kt
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
Lines changed: 25 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| 27 | + | |
25 | 28 | | |
26 | | - | |
| 29 | + | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
30 | | - | |
| 34 | + | |
| 35 | + | |
31 | 36 | | |
32 | 37 | | |
33 | | - | |
34 | 38 | | |
35 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
36 | 42 | | |
37 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
38 | 50 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
44 | 57 | | |
45 | 58 | | |
Lines changed: 63 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
0 commit comments