Skip to content

Commit 38ab7d1

Browse files
Run non-release-blocking e2e tests independently (#8932)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1215827024665943?focus=true Tech Design URL (if applicable): ### Description Test suites in the non-release-blocking e2e nightly (`e2e-nightly-non-blockers-suite.yml`) ran as sequential steps in a single job. GitHub Actions stops a job at the first failing step, so when an early suite (e.g. Unified Input Field) failed, every suite after it (e.g. Internal Onboarding Flows) was skipped. The suites are independent — each only needs the Maestro binary that was uploaded earlier in the job — so a single failure hid all subsequent failures until the next nightly. This adds an `if: ${{ !cancelled() && steps.<upload>.outcome == 'success' }}` guard to each of the five test-suite steps so every suite runs regardless of earlier suite failures, gated only on the binary it consumes. ### Steps to test this PR CI passes ### UI changes | Before | After | | ------ | ----- | | No UI changes | No UI changes | Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 11a0eb9 commit 38ab7d1

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

.github/workflows/e2e-nightly-non-blockers-suite.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ jobs:
7272

7373
- name: Omnibar Tests
7474
id: maestro-omnibar
75+
# Run regardless of earlier suite failures, but only if the release binary uploaded.
76+
if: ${{ !cancelled() && steps.maestro-upload-release-binary.outcome == 'success' }}
7577
uses: ./.github/actions/maestro-cloud-asana-reporter
7678
timeout-minutes: 120
7779
with:
@@ -89,6 +91,8 @@ jobs:
8991

9092
- name: Run Duck Player Maestro Tests
9193
id: maestro-cloud-asana
94+
# Run regardless of earlier suite failures, but only if the internal binary uploaded.
95+
if: ${{ !cancelled() && steps.maestro-upload-internal-binary.outcome == 'success' }}
9296
uses: ./.github/actions/maestro-cloud-asana-reporter
9397
timeout-minutes: 120
9498
with:
@@ -106,6 +110,8 @@ jobs:
106110

107111
- name: Android Design System
108112
id: maestro-ads
113+
# Run regardless of earlier suite failures, but only if the internal binary uploaded.
114+
if: ${{ !cancelled() && steps.maestro-upload-internal-binary.outcome == 'success' }}
109115
uses: ./.github/actions/maestro-cloud-asana-reporter
110116
timeout-minutes: 120
111117
with:
@@ -123,6 +129,8 @@ jobs:
123129

124130
- name: Unified Input Field
125131
id: maestro-uif
132+
# Run regardless of earlier suite failures, but only if the internal binary uploaded.
133+
if: ${{ !cancelled() && steps.maestro-upload-internal-binary.outcome == 'success' }}
126134
uses: ./.github/actions/maestro-cloud-asana-reporter
127135
timeout-minutes: 120
128136
with:
@@ -140,6 +148,8 @@ jobs:
140148

141149
- name: Internal Onboarding Flows
142150
id: maestro-preonboarding
151+
# Run regardless of earlier suite failures, but only if the internal binary uploaded.
152+
if: ${{ !cancelled() && steps.maestro-upload-internal-binary.outcome == 'success' }}
143153
uses: ./.github/actions/maestro-cloud-asana-reporter
144154
timeout-minutes: 120
145155
with:

0 commit comments

Comments
 (0)