Skip to content

Commit 65337eb

Browse files
committed
Match rename-menu string names to how they are used
The confirm action read its visible label from a string named ..._content_description, which lied about the resource's role. Split into ..._confirm_title ("Save") for android:title and keep ..._confirm_content_description ("Save chat title") for the new android:contentDescription binding, so each string is wired to the attribute its name implies.
1 parent 81c64f8 commit 65337eb

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

duckchat/duckchat-impl/src/main/res/menu/menu_rename_chat.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@
1818
xmlns:app="http://schemas.android.com/apk/res-auto">
1919
<item
2020
android:id="@+id/action_rename_confirm"
21+
android:contentDescription="@string/duck_ai_chat_history_rename_confirm_content_description"
2122
android:enabled="false"
2223
android:icon="@drawable/ic_check_24"
23-
android:title="@string/duck_ai_chat_history_rename_confirm_content_description"
24+
android:title="@string/duck_ai_chat_history_rename_confirm_title"
2425
app:showAsAction="always" />
2526
</menu>

duckchat/duckchat-impl/src/main/res/values/donottranslate.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@
104104
<string name="duck_ai_chat_history_exit_select_mode_content_description">Exit selection mode</string>
105105
<string name="duck_ai_chat_history_rename_title">Rename Chat</string>
106106
<string name="duck_ai_chat_history_rename_chat_title_hint">Chat Title</string>
107-
<string name="duck_ai_chat_history_rename_confirm_content_description">Save</string>
107+
<string name="duck_ai_chat_history_rename_confirm_title">Save</string>
108+
<string name="duck_ai_chat_history_rename_confirm_content_description">Save chat title</string>
108109
<string name="duck_ai_chat_history_rename_error">Couldn\'t rename chat</string>
109110
</resources>

0 commit comments

Comments
 (0)