Skip to content

Commit 7827f91

Browse files
committed
Restructure autofill UI tests, ensure critical tests are considered release blockers
1 parent 04479f8 commit 7827f91

3 files changed

Lines changed: 43 additions & 83 deletions

File tree

.github/workflows/e2e-nightly-autofill.yml

Lines changed: 0 additions & 81 deletions
This file was deleted.

.github/workflows/e2e-nightly-full-suite.yml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
release_properties: ${{ secrets.FAKE_RELEASE_PROPERTIES }}
7070
release_key: ${{ secrets.FAKE_RELEASE_KEY }}
7171
gradle_encryption_key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
72-
gradle_flags: '-Pddg.di=${{ env.DDG_DI }}'
72+
gradle_flags: '-Pautofill-disable-auth-requirement -Pddg.di=${{ env.DDG_DI }}'
7373
develocity_access_key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
7474
ducksans_package_auth_user: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION_USER }}
7575
ducksans_package_auth_token: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION }}
@@ -110,6 +110,28 @@ jobs:
110110
test_suite_name: Release Binary Upload${{ env.DI_PAREN_SUFFIX }}
111111
create_asana_error_task: ${{ inputs.create_asana_tasks }}
112112

113+
- name: Autofill Critical Path
114+
id: maestro-autofill-critical
115+
uses: ./.github/actions/maestro-cloud-asana-reporter
116+
timeout-minutes: 120
117+
with:
118+
maestro_api_key: ${{ secrets.ROBIN_API_KEY }}
119+
maestro_project_id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
120+
maestro_test_name: autofillCriticalPath${{ env.DI_UNDERSCORE_SUFFIX }}_${{ github.sha }}
121+
maestro_timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
122+
maestro_app_binary_id: ${{ steps.maestro-upload-release-binary.outputs.maestro_app_binary_id }}
123+
maestro_api_level: 34
124+
maestro_include_tags: autofillNoAuthTests
125+
asana_pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
126+
asana_project_id: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
127+
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
128+
test_suite_name: Autofill Critical Path (${{ env.DDG_DI == 'AnvilDagger' && 'Nightly' || format('{0} Nightly', env.DDG_DI) }})
129+
create_asana_error_task: ${{ inputs.create_asana_tasks }}
130+
# Only block releases for the default Anvil path. Metro is informational.
131+
is_release_blocker: ${{ env.DDG_DI == 'AnvilDagger' }}
132+
asana_releases_project_id: ${{ vars.GH_ANDROID_APP_RELEASES_PROJECT_ID }}
133+
asana_releases_blocker_section_id: ${{ vars.GH_ANDROID_APP_RELEASES_PROJECT_BLOCKER_SECTION_ID }}
134+
113135
- name: Custom tabs flows
114136
id: maestro-custom-tabs
115137
uses: ./.github/actions/maestro-cloud-asana-reporter

.github/workflows/e2e-nightly-non-blockers-suite.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
gradle_encryption_key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
3232
# Disable the 50/50 onboardingQuickSetupExperimentJun3 A/B experiment so the
3333
# preonboarding tests don't randomly fail when enrolled in the TREATMENT cohort
34-
gradle_flags: '-Pconfig_patches=.maestro/onboarding/remote_config_patches/disable_onboarding_quick_setup_experiment.json,.maestro/duckplayer/patches/ad_blocking_enabled_patch.json'
34+
gradle_flags: '-Pautofill-disable-auth-requirement -Pconfig_patches=.maestro/onboarding/remote_config_patches/disable_onboarding_quick_setup_experiment.json,.maestro/duckplayer/patches/ad_blocking_enabled_patch.json'
3535
develocity_access_key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
3636
ducksans_package_auth_user: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION_USER }}
3737
ducksans_package_auth_token: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION }}
@@ -70,6 +70,25 @@ jobs:
7070
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
7171
test_suite_name: Release Binary Upload
7272

73+
- name: Autofill Web Flows
74+
id: maestro-autofill-web
75+
# Run regardless of earlier suite failures, but only if the release binary uploaded.
76+
if: ${{ !cancelled() && steps.maestro-upload-release-binary.outcome == 'success' }}
77+
uses: ./.github/actions/maestro-cloud-asana-reporter
78+
timeout-minutes: 120
79+
with:
80+
maestro_api_key: ${{ secrets.ROBIN_API_KEY }}
81+
maestro_project_id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
82+
maestro_test_name: autofill_secondary_functionality_${{ github.sha }}
83+
maestro_timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
84+
maestro_app_binary_id: ${{ steps.maestro-upload-release-binary.outputs.maestro_app_binary_id }}
85+
maestro_api_level: 34
86+
maestro_include_tags: autofillBackfillingUsername,autofillPasswordGeneration
87+
asana_pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
88+
asana_project_id: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
89+
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
90+
test_suite_name: Autofill Web Flows
91+
7392
- name: Run Duck Player Maestro Tests
7493
id: maestro-cloud-asana
7594
# Run regardless of earlier suite failures, but only if the internal binary uploaded.

0 commit comments

Comments
 (0)