Skip to content

Commit a9c6575

Browse files
authored
Fix Figma sign-in Custom Tab issue (#8559)
Task/Issue URL: https://app.asana.com/1/137249556945/inbox/1200776578788342/item/1211781703927439/story/1214603116952132?focus=true ### Description When users tapped to sign in to the Figma app, the sign-in Custom Tab wasn't opening inside of the Figma app as expected, this meant users could get stuck in our browser while trying to sign in (e.g. if they closed the sign in page). It turned out that the Custom Tab intent flags were being cleared, since instead of combining them (with bitwise OR), we were effectively clearing them (with bitwise AND). ### Steps to test this PR 1. Open DuckDuckGo and make sure it is the default browser - *(Opening the browser here, even if already default might be needed.)* 2. Install Figma Android app (or sign out if already installed) 3. Open Figma app, and tap Sign In 4. Press X to close Figma sign in window. 5. Make sure you are taken back to the Figma app, instead of being left in the DuckDuckGo Browser.
1 parent 259fa01 commit a9c6575

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

app/src/main/java/com/duckduckgo/app/dispatchers/IntentDispatcherActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class IntentDispatcherActivity : DuckDuckGoActivity() {
7070
startActivity(
7171
CustomTabActivity.intent(
7272
context = this,
73-
flags = Intent.FLAG_ACTIVITY_NEW_TASK and Intent.FLAG_ACTIVITY_CLEAR_TASK and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS,
73+
flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS,
7474
text = intentText,
7575
toolbarColor = toolbarColor,
7676
isExternal = isExternal,

0 commit comments

Comments
 (0)