Remove unused field

landomen · landomen · commit e6537d7a14e2 · 2026-05-26T08:39:49.000Z
diff --git a/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandler.kt b/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandler.kt
@@ -109,7 +109,6 @@ class ExecuteBrokerStepActionEventHandler @Inject constructor(
                     GetEmailForProfile(
                         actionId = actionToExecute.id,
                         brokerName = currentBrokerStep.broker.name,
-                        profileQuery = state.profileQuery,
                     ),
                 )
             } else if (actionToExecute is GenerateEmail) {
@@ -123,7 +122,6 @@ class ExecuteBrokerStepActionEventHandler @Inject constructor(
                     sideEffect = GetEmailForProfile(
                         actionId = actionToExecute.id,
                         brokerName = currentBrokerStep.broker.name,
-                        profileQuery = state.profileQuery,
                     ),
                 )
             } else {
diff --git a/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/common/actions/PirActionsRunnerStateEngine.kt b/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/common/actions/PirActionsRunnerStateEngine.kt
@@ -174,7 +174,6 @@ interface PirActionsRunnerStateEngine {
         data class GetEmailForProfile(
             override val actionId: String,
             val brokerName: String,
-            val profileQuery: ProfileQuery?,
         ) : SideEffect(),
             BrokerActionSideEffect
 
diff --git a/pir/pir-impl/src/test/kotlin/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandlerTest.kt b/pir/pir-impl/src/test/kotlin/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandlerTest.kt
@@ -224,7 +224,6 @@ class ExecuteBrokerStepActionEventHandlerTest {
         val sideEffect = result.sideEffect as GetEmailForProfile
         assertEquals("action-1", sideEffect.actionId)
         assertEquals(testBrokerName, sideEffect.brokerName)
-        assertEquals(testProfileQuery, sideEffect.profileQuery)
         assertNull(result.nextEvent)
     }
 
@@ -721,7 +720,6 @@ class ExecuteBrokerStepActionEventHandlerTest {
         val sideEffect = result.sideEffect as GetEmailForProfile
         assertEquals("action-gen-email", sideEffect.actionId)
         assertEquals(testBrokerName, sideEffect.brokerName)
-        assertEquals(testProfileQuery, sideEffect.profileQuery)
         assertNull(result.nextEvent)
     }
 
@@ -756,7 +754,6 @@ class ExecuteBrokerStepActionEventHandlerTest {
         val sideEffect = result.sideEffect as GetEmailForProfile
         assertEquals("action-gen-email", sideEffect.actionId)
         assertEquals(testBrokerName, sideEffect.brokerName)
-        assertEquals(testProfileQuery, sideEffect.profileQuery)
         assertNull(result.nextEvent)
     }
 
@@ -793,7 +790,6 @@ class ExecuteBrokerStepActionEventHandlerTest {
         val sideEffect = result.sideEffect as GetEmailForProfile
         assertEquals("action-gen-email", sideEffect.actionId)
         assertEquals(testBrokerName, sideEffect.brokerName)
-        assertEquals(testProfileQuery, sideEffect.profileQuery)
         assertNull(result.nextEvent)
     }
 }
diff --git a/pir/pir-impl/src/test/kotlin/com/duckduckgo/pir/impl/common/actions/RealPirActionsRunnerStateEngineTest.kt b/pir/pir-impl/src/test/kotlin/com/duckduckgo/pir/impl/common/actions/RealPirActionsRunnerStateEngineTest.kt
@@ -928,7 +928,6 @@ class RealPirActionsRunnerStateEngineTest {
         val testSideEffect = SideEffect.GetEmailForProfile(
             actionId = "action-1",
             brokerName = testBrokerName,
-            profileQuery = testProfileQuery,
         )
 
         whenever(mockEventHandler.event).thenReturn(Event.Started::class)

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,6 @@ class ExecuteBrokerStepActionEventHandlerTest {`
`224`	`224`	`val sideEffect = result.sideEffect as GetEmailForProfile`
`225`	`225`	`assertEquals("action-1", sideEffect.actionId)`
`226`	`226`	`assertEquals(testBrokerName, sideEffect.brokerName)`
`227`		`- assertEquals(testProfileQuery, sideEffect.profileQuery)`
`228`	`227`	`assertNull(result.nextEvent)`
`229`	`228`	`}`
`230`	`229`
`@@ -721,7 +720,6 @@ class ExecuteBrokerStepActionEventHandlerTest {`
`721`	`720`	`val sideEffect = result.sideEffect as GetEmailForProfile`
`722`	`721`	`assertEquals("action-gen-email", sideEffect.actionId)`
`723`	`722`	`assertEquals(testBrokerName, sideEffect.brokerName)`
`724`		`- assertEquals(testProfileQuery, sideEffect.profileQuery)`
`725`	`723`	`assertNull(result.nextEvent)`
`726`	`724`	`}`
`727`	`725`
`@@ -756,7 +754,6 @@ class ExecuteBrokerStepActionEventHandlerTest {`
`756`	`754`	`val sideEffect = result.sideEffect as GetEmailForProfile`
`757`	`755`	`assertEquals("action-gen-email", sideEffect.actionId)`
`758`	`756`	`assertEquals(testBrokerName, sideEffect.brokerName)`
`759`		`- assertEquals(testProfileQuery, sideEffect.profileQuery)`
`760`	`757`	`assertNull(result.nextEvent)`
`761`	`758`	`}`
`762`	`759`
`@@ -793,7 +790,6 @@ class ExecuteBrokerStepActionEventHandlerTest {`
`793`	`790`	`val sideEffect = result.sideEffect as GetEmailForProfile`
`794`	`791`	`assertEquals("action-gen-email", sideEffect.actionId)`
`795`	`792`	`assertEquals(testBrokerName, sideEffect.brokerName)`
`796`		`- assertEquals(testProfileQuery, sideEffect.profileQuery)`
`797`	`793`	`assertNull(result.nextEvent)`
`798`	`794`	`}`
`799`	`795`	`}`
Original file line number	Diff line number	Diff line change
`@@ -928,7 +928,6 @@ class RealPirActionsRunnerStateEngineTest {`
`928`	`928`	`val testSideEffect = SideEffect.GetEmailForProfile(`
`929`	`929`	`actionId = "action-1",`
`930`	`930`	`brokerName = testBrokerName,`
`931`		`- profileQuery = testProfileQuery,`
`932`	`931`	`)`
`933`	`932`
`934`	`933`	`whenever(mockEventHandler.event).thenReturn(Event.Started::class)`