Stop swallowing CancellationException on rename

runCatching catches Throwable, so the previous shape silently absorbed
CancellationException and surfaced it as a RenameResult.Error. That
breaks structured concurrency: a cancelled scope should propagate
upwards, not be reported as a rename failure. Swap to a try/catch
that rethrows CancellationException and only converts Exception into
the user-visible error state.

Author: GerardPaligot

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/history/RenameChatViewModel.kt

@@ -20,6 +20,7 @@ import androidx.lifecycle.ViewModel
 import com.duckduckgo.anvil.annotations.ContributesViewModel
 import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.di.scopes.FragmentScope
+import kotlinx.coroutines.CancellationException
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.channels.BufferOverflow
 import kotlinx.coroutines.channels.Channel
@@ -39,9 +40,14 @@ class RenameChatViewModel @Inject constructor(
 
     fun onSaveClicked(chatId: String, newTitle: String) {
         appScope.launch {
-            runCatching { chatHistoryRepository.renameChat(chatId, newTitle.trim()) }
-                .onSuccess { resultChannel.trySend(RenameResult.Success) }
-                .onFailure { error -> resultChannel.trySend(RenameResult.Error(error)) }
+            try {
+                chatHistoryRepository.renameChat(chatId, newTitle.trim())
+                resultChannel.trySend(RenameResult.Success)
+            } catch (e: CancellationException) {
+                throw e
+            } catch (e: Exception) {
+                resultChannel.trySend(RenameResult.Error(e))
+            }
         }
     }