Also use AdBlockingStatusChecker in AdBlockingSettings

Author: CrisBarreiro

ad-blocking/ad-blocking-impl/src/main/java/com/duckduckgo/adblocking/impl/domain/AdBlockingStatusChecker.kt

@@ -31,6 +31,7 @@ import javax.inject.Inject
 
 interface AdBlockingStatusChecker {
     fun canInject(): Boolean
+    fun isShownInSettings(): Boolean
 }
 
 @SingleInstanceIn(AppScope::class)
@@ -59,4 +60,6 @@ class RealAdBlockingStatusChecker @Inject constructor(
         }
         return true
     }
+
+    override fun isShownInSettings(): Boolean = feature.isDiscoverable().isEnabled()
 }

ad-blocking/ad-blocking-impl/src/main/java/com/duckduckgo/adblocking/impl/ui/AdBlockingSettings.kt

@@ -19,7 +19,7 @@ package com.duckduckgo.adblocking.impl.ui
 import android.content.Context
 import android.view.View
 import com.duckduckgo.adblocking.impl.R
-import com.duckduckgo.adblocking.impl.remoteconfig.AdBlockingExtensionFeature
+import com.duckduckgo.adblocking.impl.domain.AdBlockingStatusChecker
 import com.duckduckgo.anvil.annotations.PriorityKey
 import com.duckduckgo.common.ui.view.listitem.OneLineListItem
 import com.duckduckgo.di.scopes.ActivityScope
@@ -33,11 +33,11 @@ import com.duckduckgo.mobile.android.R as CommonR
 @PriorityKey(150)
 class AdBlockingSettingsEntry @Inject constructor(
     private val globalActivityStarter: GlobalActivityStarter,
-    private val feature: AdBlockingExtensionFeature,
+    private val statusChecker: AdBlockingStatusChecker,
 ) : AdBlockingSettingsPlugin {
 
     override fun getView(context: Context): View {
-        if (!feature.isDiscoverable().isEnabled()) {
+        if (!statusChecker.isShownInSettings()) {
             return View(context).apply { visibility = View.GONE }
         }
         return OneLineListItem(context).apply {

ad-blocking/ad-blocking-impl/src/test/java/com/duckduckgo/adblocking/impl/domain/RealAdBlockingStatusCheckerTest.kt

@@ -93,4 +93,16 @@ class RealAdBlockingStatusCheckerTest {
 
         assertFalse(checker.canInject())
     }
+
+    @Test
+    fun whenDiscoverableFlagEnabledThenIsShownInSettings() {
+        assertTrue(checker.isShownInSettings())
+    }
+
+    @Test
+    fun whenDiscoverableFlagDisabledThenIsNotShownInSettings() {
+        discoverableEnabled = false
+
+        assertFalse(checker.isShownInSettings())
+    }
 }