GHA: Simplify CI flow by malmstein · Pull Request #7301 · duckduckgo/Android

malmstein · 2025-12-05T20:57:50Z

Task/Issue URL:

Description

Steps to test this PR

Feature 1

[ ]
[ ]

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

daxmobile

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:31: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 136 in 932adb8

run: |

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:52: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 163 in 932adb8

run: |

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:9:46: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 176 in 932adb8

run: |

🚫 [actionlint] _{reported by reviewdog 🐶}
property "gh_asana_workspace_id" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_internal.yml

Line 176 in 932adb8

run: |

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 71 in 932adb8

secret: ${{ secrets.UPLOAD_RELEASE_PROPERTIES }}

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 78 in 932adb8

secret: ${{ secrets.UPLOAD_RELEASE_KEY }}

🚫 [actionlint] _{reported by reviewdog 🐶}
property "malicious_site_protection_auth_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 91 in 932adb8

    
           MALICIOUS_SITE_PROTECTION_AUTH_TOKEN: ${{ secrets.MALICIOUS_SITE_PROTECTION_AUTH_TOKEN }}

daxmobile · 2025-12-05T20:58:07Z

          fetch-depth: 0 # required due to setting Spotless ratchetFrom
          submodules: recursive
+          token: ${{ secrets.GT_DAXMOBILE }}
+          ref: ${{ github.event.inputs.ref }}


🚫 [actionlint] _{reported by reviewdog 🐶}
property "ref" is not defined in object type {} [expression]

daxmobile · 2025-12-05T20:58:07Z

+        required: true
+
+env:
+  ASANA_PAT: ${{ secrets.ASANA_ACCESS_TOKEN }}


🚫 [actionlint] _{reported by reviewdog 🐶}
property "asana_access_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; github_token: string; mm_auth_token: string; mm_team_id: string} [expression]

daxmobile · 2025-12-05T20:58:07Z

+    outputs:
+      asana-task-url:
+        description: "The URL of the created Asana task"
+        value: ${{ jobs.create_release_task.outputs.asana_task_url }}


🚫 [actionlint] _{reported by reviewdog 🐶}
property "asana_task_url" is not defined in object type {} [expression]

daxmobile · 2025-12-05T20:58:07Z

+    name: 'Step 1: Notify Mattermost of Release start'
+    uses: ./.github/workflows/notify_mattermost.yml
+    with:
+      mattermost-message: ${{env.emoji_start}} Starting release process for version ${{ github.event.inputs.app-version }}


🚫 [actionlint] _{reported by reviewdog 🐶}
context "env" is not allowed here. available contexts are "github", "inputs", "matrix", "needs", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details [expression]

daxmobile · 2025-12-05T20:58:07Z

+
+  create_task:
+    name: 'Step 2: Create Asana Task'
+    uses: ./.github/workflows/release_create_task.yml


🚫 [actionlint] _{reported by reviewdog 🐶}
secret "ASANA_ACCESS_TOKEN" is required by "./.github/workflows/release_create_task.yml" reusable workflow [workflow-call]

daxmobile · 2025-12-05T20:58:07Z

+      asana-task-url: ${{ needs.create_task.outputs.asana-task-url }}
+    secrets: inherit
+
+  upload_internal:


🚫 [actionlint] _{reported by reviewdog 🐶}
job "upload_internal" needs job "run_tests" which does not exist in this workflow [job-needs]

daxmobile · 2025-12-05T20:58:07Z

+    needs: run_tests
+    uses: ./.github/workflows/release_upload_internal.yml
+    with:
+      app-version: ${{ github.event.inputs.app-version }}


🚫 [actionlint] _{reported by reviewdog 🐶}
input "app-version" is not defined in "./.github/workflows/release_upload_internal.yml" reusable workflow. no input is defined [workflow-call]

daxmobile · 2025-12-05T20:58:07Z

+    uses: ./.github/workflows/release_upload_internal.yml
+    with:
+      app-version: ${{ github.event.inputs.app-version }}
+      asana-task-url: ${{ needs.create_task.outputs.asana-task-url }}


🚫 [actionlint] _{reported by reviewdog 🐶}
input "asana-task-url" is not defined in "./.github/workflows/release_upload_internal.yml" reusable workflow. no input is defined [workflow-call]

daxmobile · 2025-12-05T20:58:07Z

+    uses: ./.github/workflows/release_upload_internal.yml
+    with:
+      app-version: ${{ github.event.inputs.app-version }}
+      asana-task-url: ${{ needs.create_task.outputs.asana-task-url }}


🚫 [actionlint] _{reported by reviewdog 🐶}
property "create_task" is not defined in object type {} [expression]

daxmobile · 2025-12-05T20:58:07Z

+    uses: ./.github/workflows/notify_mattermost.yml
+    needs: upload_play_store
+    with:
+      mattermost-message: ${{env.emoji_end}} Release ${{ github.event.inputs.app-version }} completed successfully and is now in review.


🚫 [actionlint] _{reported by reviewdog 🐶}
context "env" is not allowed here. available contexts are "github", "inputs", "matrix", "needs", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details [expression]

daxmobile · 2025-12-05T20:58:09Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:9:24: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_create_task.yml

Line 85 in 932adb8

run: |

daxmobile · 2025-12-05T20:58:10Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:12:38: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_create_task.yml

Line 85 in 932adb8

run: |

daxmobile · 2025-12-05T20:58:11Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:16:22: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_create_task.yml

Line 85 in 932adb8

run: |

daxmobile · 2025-12-05T20:58:11Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:3:30: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 63 in 932adb8

run: |

daxmobile · 2025-12-05T20:58:12Z

🚫 [actionlint] _{reported by reviewdog 🐶}
input "github_token" is not defined in action "Check for code changes after a specific tag" defined at "./.github/actions/check-for-changes-since-tag". available inputs are "tag" [action]

Android/.github/workflows/release_upload_internal.yml

Line 72 in 932adb8

github_token: ${{ secrets.GT_DAXMOBILE }}

daxmobile · 2025-12-05T20:58:12Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:73: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 77 in 932adb8

run: |

daxmobile · 2025-12-05T20:58:13Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_internal.yml

Line 86 in 932adb8

secret: ${{ secrets.UPLOAD_RELEASE_PROPERTIES }}

daxmobile · 2025-12-05T20:58:13Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_internal.yml

Line 94 in 932adb8

secret: ${{ secrets.UPLOAD_RELEASE_KEY }}

malmstein · 2025-12-05T20:58:14Z

GHA: Simplify CI flow #7301 👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

daxmobile · 2025-12-05T20:58:14Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "netp_debug_server_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_internal.yml

Line 121 in 932adb8

NETP_DEBUG_SERVER_TOKEN: ${{ secrets.NETP_DEBUG_SERVER_TOKEN }}

daxmobile · 2025-12-05T20:58:15Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:27: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 129 in 932adb8

run: |

daxmobile · 2025-12-05T21:06:15Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:31: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 136 in 2e4792f

run: |

daxmobile · 2025-12-05T21:06:16Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:52: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 163 in 2e4792f

run: |

daxmobile · 2025-12-05T21:06:16Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:9:46: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_upload_internal.yml

Line 176 in 2e4792f

run: |

daxmobile · 2025-12-05T21:06:17Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "gh_asana_workspace_id" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_internal.yml

Line 176 in 2e4792f

run: |

daxmobile · 2025-12-05T21:06:18Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 71 in 2e4792f

secret: ${{ secrets.UPLOAD_RELEASE_PROPERTIES }}

daxmobile · 2025-12-05T21:06:18Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 78 in 2e4792f

secret: ${{ secrets.UPLOAD_RELEASE_KEY }}

daxmobile · 2025-12-05T21:06:19Z

🚫 [actionlint] _{reported by reviewdog 🐶}
property "malicious_site_protection_auth_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]

Android/.github/workflows/release_upload_play_store.yml

Line 91 in 2e4792f

MALICIOUS_SITE_PROTECTION_AUTH_TOKEN: ${{ secrets.MALICIOUS_SITE_PROTECTION_AUTH_TOKEN }}

daxmobile · 2025-12-05T21:19:28Z

+      test-tag:
+        description: 'Maestro Tests tag to include'
+        required: true
+        default: 'releaseTest'


🚫 [actionlint] _{reported by reviewdog 🐶}
input "test-tag" of workflow_call event has the default value "releaseTest", but it is also required. if an input is marked as required, its default value will never be used [events]

daxmobile · 2025-12-05T21:19:30Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:45:45: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_tests.yml

Line 118 in 51fd7c3

run: |

malmstein added 4 commits December 5, 2025 17:14

GHA: Simplify CI flow

516c26f

make it callable

70d043f

test sequential release

78a056a

update test worflow

932adb8

daxmobile reviewed Dec 5, 2025

View reviewed changes

pass emoki properly

2e4792f

daxmobile reviewed Dec 5, 2025

View reviewed changes

malmstein added 2 commits December 5, 2025 22:08

standard emoji

62a2f6d

add on call secrets

51fd7c3

daxmobile reviewed Dec 5, 2025

View reviewed changes

malmstein added 2 commits December 5, 2025 22:20

proper spacing

7de0104

proper mm inputs

353735d

malmstein closed this Jan 28, 2026

malmstein deleted the feature/david/06-10-gha_simplify_ci_flow branch April 2, 2026 13:28

Conversation

malmstein commented Dec 5, 2025

Description

Steps to test this PR

UI changes

Uh oh!

daxmobile left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malmstein commented Dec 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants