Fire Mode: Rename fire-mode module to browser-mode#8574
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
0nko
commented
May 15, 2026
| && dependencyPath != ":navigation-api" | ||
| && dependencyPath != ":js-messaging-api" | ||
| && dependencyPath != ":browser-api" | ||
| && dependencyPath != ":browser-mode-api" |
Member
Author
There was a problem hiding this comment.
BrowserMode type is needed in other APIs.
0nko
force-pushed
the
feature/ondrej/fire-mode-rename-modules
branch
from
edcf6dd to
19ab411
Compare
CDRussell
approved these changes
May 15, 2026
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1214778997953222?focus=true
Description
This PR replaces the
fire-mode-*modules withbrowser-mode-*modules so that the everything related to the Browser modes can be moved there.The
browser-mode-apiis added to the exception list for api->api dependence, which has already been been approved in the API proposal/tech design.Steps to test this PR
QA-optional
Note
Medium Risk
Mostly a module/package rename, but it touches Gradle dependency wiring and DI bindings across the app; build/merge issues or missing imports are the main risk rather than behavioral changes.
Overview
Renames the
fire-mode-*modules tobrowser-mode-*and moves the public APIs (BrowserMode,BrowserModeStateHolder,FireModeAvailability, etc.) under the newcom.duckduckgo.browsermode.apinamespace.Updates app and feature modules (e.g.,
BrowserActivity,BrowserViewModel, DuckChat) to depend on and import frombrowser-mode-*, and adjusts Gradle rules to allow:browser-mode-apias an approvedapi→apidependency. Thebrowser-mode-implbuild config is updated with additional AndroidX dependencies and unit-test (Robolectric/resource) support.Reviewed by Cursor Bugbot for commit 19ab411. Bugbot is set up for automated code reviews on this repo. Configure here.