Skip to content

PIR: Update completeRequestData to support scans and email extracted data#8583

Merged
landomen merged 2 commits into
developfrom
feature/domen/pir-email-flexibility-complete-request-data
May 26, 2026
Merged

PIR: Update completeRequestData to support scans and email extracted data#8583
landomen merged 2 commits into
developfrom
feature/domen/pir-email-flexibility-complete-request-data

Conversation

@landomen

@landomen landomen commented May 15, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213993026941873?focus=true

Description

Updates completeRequestData() to support scans and email extracted data

Steps to test this PR

Will be testable later when feature is complete.

UI changes

No UI changes


Note

Medium Risk
Changes broker opt-out/scan form-fill payload assembly and retry behavior after email polling, which can affect automation success if edge cases are wrong.

Overview
PIR broker automation now builds richer extracted profile payloads for JS FillForm actions that use EXTRACTED_PROFILE, and clears action retries after email polling succeeds.

completeRequestData now takes full runner state instead of separate profile/email args. It still fills opt-out and email-confirmation steps from profileToOptOut, but scan steps only attach an extracted profile when generated email exists (minimal params, not a broker profile). Generated email and polled email extracted data (e.g. verification codes) are merged into ExtractedProfileParams; empty maps omit emailExtractedData. EmailDataReceived resets actionRetryCount to 0 when advancing after GetEmailData. Tests cover scan vs opt-out combinations and the retry reset.

Reviewed by Cursor Bugbot for commit aab3e52. Bugbot is set up for automated code reviews on this repo. Configure here.

@landomen landomen force-pushed the feature/domen/pir-email-flexibility-polling branch from f7a3f45 to de20666 Compare May 19, 2026 11:00
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-complete-request-data branch from bc43e3d to 72e7b4b Compare May 19, 2026 11:00
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-polling branch from de20666 to 8f49ae6 Compare May 21, 2026 17:48
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-complete-request-data branch 2 times, most recently from 0fa4b73 to d736d56 Compare May 22, 2026 06:46
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-polling branch from 8f49ae6 to 90eb151 Compare May 22, 2026 06:46

@marcosholgado marcosholgado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosholgado marcosholgado self-assigned this May 25, 2026

landomen commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 26, 8:20 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 9:28 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 9:41 AM UTC: @landomen merged this pull request with Graphite.

@landomen landomen changed the base branch from feature/domen/pir-email-flexibility-polling to graphite-base/8583 May 26, 2026 09:10
@landomen landomen changed the base branch from graphite-base/8583 to develop May 26, 2026 09:27
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-complete-request-data branch from d736d56 to aab3e52 Compare May 26, 2026 09:27
@landomen landomen merged commit 3ee1f7d into develop May 26, 2026
13 checks passed
@landomen landomen deleted the feature/domen/pir-email-flexibility-complete-request-data branch May 26, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants