Skip to content

PIR: Clear emailExtractedData on step completion#8612

Merged
landomen merged 1 commit into
developfrom
feature/domen/pir-email-flexibility-clear-on-completion
May 26, 2026
Merged

PIR: Clear emailExtractedData on step completion#8612
landomen merged 1 commit into
developfrom
feature/domen/pir-email-flexibility-clear-on-completion

Conversation

@landomen

@landomen landomen commented May 19, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213993026941875?focus=true

Description

Clear emailExtractedData on step completion

Steps to test this PR

Will be testable on later PRs once the whole feature is complete

UI changes

No UI changes


Note

Low Risk
Small state-reset change in the PIR runner with a focused unit test; no auth or external API changes.

Overview
When a broker step finishes, the PIR actions runner now resets emailExtractedData to an empty map in the same transition that already clears generatedEmailData and advances to the next step—so values like verification codes from email polling do not carry into the next broker step’s actions.

A unit test was updated to seed non-empty emailExtractedData and assert the post-completion state is empty.

Reviewed by Cursor Bugbot for commit 490a00a. Bugbot is set up for automated code reviews on this repo. Configure here.

@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from bc869a1 to f6b07d2 Compare May 19, 2026 11:00
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from f6b07d2 to 73245d0 Compare May 21, 2026 17:48
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-complete-request-data branch from 0fa4b73 to d736d56 Compare May 22, 2026 06:46
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from 73245d0 to 733cabf Compare May 22, 2026 06:46

@marcosholgado marcosholgado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosholgado marcosholgado self-assigned this May 25, 2026

landomen commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 26, 8:20 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 9:43 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 9:54 AM UTC: @landomen merged this pull request with Graphite.

@landomen landomen changed the base branch from feature/domen/pir-email-flexibility-complete-request-data to graphite-base/8612 May 26, 2026 09:27
@landomen landomen changed the base branch from graphite-base/8612 to develop May 26, 2026 09:42
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from 733cabf to 490a00a Compare May 26, 2026 09:42
@landomen landomen merged commit f0f5d94 into develop May 26, 2026
13 checks passed
@landomen landomen deleted the feature/domen/pir-email-flexibility-clear-on-completion branch May 26, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants