Custom Duck.ai Onboarding - intro animation#8621
Open
LukasPaczos wants to merge 25 commits into
Open
Conversation
214fb7a to
2b08444
Compare
Drops translatable 'with' string in favor of the Generic Lottie variant, which uses a '+' connector that needs no localization. Avoids the overlap/clipping edge cases that plagued the centered translated text.
Contributor
Author
|
bugbot run |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c57199a. Configure here.
doOnEnd from androidx.core.animation fires on both natural end and cancel. On fragment teardown, introAnimatorSet?.cancel() was running the post-intro block, briefly preparing and starting the Duck.ai Lottie before cleanup tore it back down. Switch to an AnimatorListenerAdapter that tracks cancel and skips the follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1214496516674986?focus=true
Description
Adds Duck.ai animation intro that will later be hooked into a custom onboarding flow. Currently unreachable.
Steps to test this PR
Clean install the app.
Verify that after title transition settles, a '+ Duck.ai' subtitle follows.
Verify that after 2 seconds a notification permission pop-up shows.
Force-close the app.
Change the theme.
Relaunch the app.
Verify '+ Duck.ai' correctly changes the color to match the theme.
Force-close the app.
Rotate device to landscape.
Relaunch the app.
Verify '+ Duck.ai' renders with an appropriate size.
Force-close the app.
Increase the device's font size.
Relaunch the app.
Verify '+ Duck.ai' scales with the font size.
Force-close the app.
If possible, try above steps on a tablet as well.
UI changes
onboarding-intro-duckai-anim-no-string.mp4
Note
Medium Risk
Updates the onboarding welcome animation sequence and timing (including when notification permission is requested) behind a new remote toggle, which could impact first-run UX if misconfigured. Changes are isolated to onboarding UI/resources with no security-sensitive logic.
Overview
Adds a new remote-config feature
customDuckAiOnboardingwith anintroAnimationtoggle (default off) to control whether a Duck.ai subtitle animation is shown during onboarding.When enabled, the Brand Design Update welcome page now plays an additional Lottie “+ Duck.ai” intro after the title settles, themes its font/color dynamically, includes it in outro/snap states, and cleans it up on view teardown. Layouts (phone/landscape/tablet) and a new raw Lottie JSON resource are updated accordingly, and the view model/test are extended to fetch and expose the toggle state.
Reviewed by Cursor Bugbot for commit 8a15d13. Bugbot is set up for automated code reviews on this repo. Configure here.